Skip to content

Service test and options builder nitpicks #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scottf merged 1 commit into from
Jan 25, 2023
Merged

Service test and options builder nitpicks #835

scottf merged 1 commit into from
Jan 25, 2023

Conversation

@scottf
Copy link
Contributor

@scottf scottf commented Jan 25, 2023

No description provided.

@arondi arondi closed this Jan 25, 2023
@arondi arondi deleted the options-builder-2 branch January 25, 2023 13:02
@arondi arondi restored the options-builder-2 branch January 25, 2023 13:03
@arondi arondi reopened this Jan 25, 2023
@arondi arondi changed the title options builder aroc Service test and options builder nitpicks Jan 25, 2023
arondi
arondi approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@arondi arondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit cc37a43 into main Jan 25, 2023
@scottf scottf deleted the options-builder-2 branch January 25, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arondi arondi arondi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottf @arondi