(2.12) Prioritized Consumer Support #1433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
commented
Sep 24, 2025
| NatsJetStreamMetaData meta = msg.metaData(); | ||
| lastStreamSeq = meta.streamSequence(); | ||
| lastConsumerSeq++; | ||
| subTrackJsMessage(msg); // for subclasses so they don't have to acquire the lock |
Contributor
Author
There was a problem hiding this comment.
trackJsMessage is called for every push or pull message. subTrackMessage added so if there is additional work to be done by a specific manager, they can do it within the lock. In this case, the pull manager needs to look for pin id
| throw new IOException("Pinned not allowed with " + label); | ||
| } | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
fetch and next cannot be pinned.
| } | ||
|
|
||
| PullRequestOptions pro = PullRequestOptions.builder(fetchConsumeOptions.getMaxMessages()) | ||
| PinnablePullRequestOptions pro = new PinnablePullRequestOptions(pmm.currentPinId, |
Contributor
Author
There was a problem hiding this comment.
I did not want to add pin id to the pull request that the user is allowed to manually make. So I made the PullRequestOptions extendable and made the PinnablePullRequestOptions to handled adding the pin.
I'm not loving this, but...
scottf
commented
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.