Merge pull request #1381 from nats-io/replace-vs-all

Use String.replace instead of String.replaceAll

Author: scottf

src/examples/java/io/nats/examples/autobench/LatencyBenchmark.java

@@ -190,7 +190,7 @@ public void printResult() {
                                             sum()) / (1e3 * (count-1));
 
         System.out.printf("| %-11s | %7s | %6s | %8.2f | %8s | +/- %6.2f |\n",
-                            getName().replaceAll("Latency ", "") + " bytes",
+                            getName().replace("Latency ", "") + " bytes",
                             NumberFormat.getIntegerInstance().format(count),
                             NumberFormat.getIntegerInstance().format(min),
                             median,

src/main/java/io/nats/client/support/JsonUtils.java

@@ -99,7 +99,7 @@ public static StringBuilder beginFormattedJson() {
     public static String endFormattedJson(StringBuilder sb) {
         sb.setLength(sb.length()-1);
         sb.append("\n}");
-        return sb.toString().replaceAll(",", ",\n    ");
+        return sb.toString().replace(",", ",\n    ");
     }
 
     /**
@@ -793,7 +793,7 @@ public static Map<String, Long> getMapOfLongs(String json) {
      */
     @Deprecated
     public static List<String> getStringList(String objectName, String json) {
-        String flat = json.replaceAll("\r", "").replaceAll("\n", "");
+        String flat = json.replace("\r", "").replace("\n", "");
         Matcher m = string_array_pattern(objectName).matcher(flat);
         if (m.find()) {
             String arrayString = m.group(1);
@@ -823,7 +823,7 @@ private static List<String> toList(String arrayString) {
      */
     @Deprecated
     public static List<Long> getLongList(String objectName, String json) {
-        String flat = json.replaceAll("\r", "").replaceAll("\n", "");
+        String flat = json.replace("\r", "").replace("\n", "");
         List<Long> list = new ArrayList<>();
         Matcher m = number_array_pattern(objectName).matcher(flat);
         if (m.find()) {

src/main/java/io/nats/client/support/ServerVersion.java

@@ -27,10 +27,10 @@ public ServerVersion(String v) {
         try {
             String[] split;
             if (v.startsWith("v")) {
-                split = v.substring(1).replaceAll("-", ".").split("\\Q.\\E");
+                split = v.substring(1).replace("-", ".").split("\\Q.\\E");
             }
             else {
-                split = v.replaceAll("-", ".").split("\\Q.\\E");
+                split = v.replace("-", ".").split("\\Q.\\E");
             }
             mjr = Integer.parseInt(split[0]);
             mnr = Integer.parseInt(split[1]);

src/test/java/io/nats/compatibility/Log.java

@@ -85,7 +85,7 @@ private static void log(String label, String extraStr, boolean error) {
             return;
         }
 
-        System.out.println(start + NEWLINE_INDENT + extraStr.replaceAll("\n", NEWLINE_INDENT));
+        System.out.println(start + NEWLINE_INDENT + extraStr.replace("\n", NEWLINE_INDENT));
     }
 
     private static String time() {