Remove MaxRepetition check, fixes #276 keeps nhapi inline with hapi

milkshakeuk · milkshakeuk · commit 7bbdbf1e6452 · 2022-02-16T09:02:19.000Z
diff --git a/src/NHapi.Base/Model/AbstractSegment.cs b/src/NHapi.Base/Model/AbstractSegment.cs
@@ -167,13 +167,6 @@ public virtual IType GetField(int number, int rep)
                     ErrorCode.APPLICATION_INTERNAL_ERROR);
             }
 
-            if (rep > items[number - 1].MaxRepetitions)
-            {
-                throw new HL7Exception(
-                    $"Can't get repetition {rep} from field {number} - maximum repetitions is only {items[number - 1].MaxRepetitions} reps.",
-                    ErrorCode.APPLICATION_INTERNAL_ERROR);
-            }
-
             // add a rep if necessary ...
             if (rep == currentReps)
             {

Original file line number	Diff line number	Diff line change
`@@ -167,13 +167,6 @@ public virtual IType GetField(int number, int rep)`
`167`	`167`	`ErrorCode.APPLICATION_INTERNAL_ERROR);`
`168`	`168`	`}`
`169`	`169`
`170`		`- if (rep > items[number - 1].MaxRepetitions)`
`171`		`- {`
`172`		`- throw new HL7Exception(`
`173`		`- $"Can't get repetition {rep} from field {number} - maximum repetitions is only {items[number - 1].MaxRepetitions} reps.",`
`174`		`- ErrorCode.APPLICATION_INTERNAL_ERROR);`
`175`		`- }`
`176`		`-`
`177`	`170`	`// add a rep if necessary ...`
`178`	`171`	`if (rep == currentReps)`
`179`	`172`	`{`