-
-
Notifications
You must be signed in to change notification settings - Fork 13
feature: enhance expand_styles_prop to merge className and style props #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesnx
reviewed
Nov 13, 2025
9eea680 to
43ef144
Compare
davesnx
reviewed
Nov 15, 2025
davesnx
reviewed
Nov 15, 2025
bff545d to
ee2723f
Compare
ee2723f to
70c9467
Compare
davesnx
approved these changes
Nov 17, 2025
davesnx
pushed a commit
to davesnx/opam-repository
that referenced
this pull request
Nov 30, 2025
CHANGES: * Expand styles prop into className and style props with optional handling by @pedrobslisboa in ml-in-barcelona/server-reason-react#324 * Lowercase components have ?key:string by @davesnx in ml-in-barcelona/server-reason-react#323 * Wrap client value on React.Upper_case_component by @pedrobslisboa in ml-in-barcelona/server-reason-react#322 * Fix remove last element on nested_modules by @pedrobslisboa in ml-in-barcelona/server-reason-react#321 * Add searchParams function to native URL by @pedrobslisboa in ml-in-barcelona/server-reason-react#320 * Add URL construct function and improve lib build by @EmileTrotignon in ml-in-barcelona/server-reason-react#317 * Specify model values at React by @pedrobslisboa in ml-in-barcelona/server-reason-react#309 * Allow async in client props by @pedrobslisboa in ml-in-barcelona/server-reason-react#315 * Improve the Fiber and Model stream context by @pedrobslisboa in ml-in-barcelona/server-reason-react#312 * Align Suspense with reason-react by @pedrobslisboa in ml-in-barcelona/server-reason-react#311 * Make client component to execute in runtime by @pedrobslisboa in ml-in-barcelona/server-reason-react#306 * Fix mismatch of the model and html on render_html by @pedrobslisboa in ml-in-barcelona/server-reason-react#305 * Fix createFromFetch interface and avoid transition on navigation by @davesnx in ml-in-barcelona/server-reason-react#299 * Change ppx execution order (styles expansion in server-reason-react) by @davesnx in ml-in-barcelona/server-reason-react#297 * Rename use function to usePromise in Experimental module by @pedrobslisboa in ml-in-barcelona/server-reason-react#298 * Add shared-folder-prefix arg to ppx by @davesnx in ml-in-barcelona/server-reason-react#294
davesnx
pushed a commit
to davesnx/opam-repository
that referenced
this pull request
Nov 30, 2025
CHANGES: * Bump lwt to 5.9.2 * Expand styles prop into className and style props with optional handling by @pedrobslisboa in ml-in-barcelona/server-reason-react#324 * Lowercase components have ?key:string by @davesnx in ml-in-barcelona/server-reason-react#323 * Wrap client value on React.Upper_case_component by @pedrobslisboa in ml-in-barcelona/server-reason-react#322 * Fix remove last element on nested_modules by @pedrobslisboa in ml-in-barcelona/server-reason-react#321 * Add searchParams function to native URL by @pedrobslisboa in ml-in-barcelona/server-reason-react#320 * Add URL construct function and improve lib build by @EmileTrotignon in ml-in-barcelona/server-reason-react#317 * Specify model values at React by @pedrobslisboa in ml-in-barcelona/server-reason-react#309 * Allow async in client props by @pedrobslisboa in ml-in-barcelona/server-reason-react#315 * Improve the Fiber and Model stream context by @pedrobslisboa in ml-in-barcelona/server-reason-react#312 * Align Suspense with reason-react by @pedrobslisboa in ml-in-barcelona/server-reason-react#311 * Make client component to execute in runtime by @pedrobslisboa in ml-in-barcelona/server-reason-react#306 * Fix mismatch of the model and html on render_html by @pedrobslisboa in ml-in-barcelona/server-reason-react#305 * Fix createFromFetch interface and avoid transition on navigation by @davesnx in ml-in-barcelona/server-reason-react#299 * Change ppx execution order (styles expansion in server-reason-react) by @davesnx in ml-in-barcelona/server-reason-react#297 * Rename use function to usePromise in Experimental module by @pedrobslisboa in ml-in-barcelona/server-reason-react#298 * Add shared-folder-prefix arg to ppx by @davesnx in ml-in-barcelona/server-reason-react#294
davesnx
pushed a commit
to davesnx/opam-repository
that referenced
this pull request
Dec 1, 2025
CHANGES: * Add upper bound to quickjs 0.2.0 * Bump lwt to 5.9.2 * Expand styles prop into className and style props with optional handling by @pedrobslisboa in ml-in-barcelona/server-reason-react#324 * Lowercase components have ?key:string by @davesnx in ml-in-barcelona/server-reason-react#323 * Wrap client value on React.Upper_case_component by @pedrobslisboa in ml-in-barcelona/server-reason-react#322 * Fix remove last element on nested_modules by @pedrobslisboa in ml-in-barcelona/server-reason-react#321 * Add searchParams function to native URL by @pedrobslisboa in ml-in-barcelona/server-reason-react#320 * Add URL construct function and improve lib build by @EmileTrotignon in ml-in-barcelona/server-reason-react#317 * Specify model values at React by @pedrobslisboa in ml-in-barcelona/server-reason-react#309 * Allow async in client props by @pedrobslisboa in ml-in-barcelona/server-reason-react#315 * Improve the Fiber and Model stream context by @pedrobslisboa in ml-in-barcelona/server-reason-react#312 * Align Suspense with reason-react by @pedrobslisboa in ml-in-barcelona/server-reason-react#311 * Make client component to execute in runtime by @pedrobslisboa in ml-in-barcelona/server-reason-react#306 * Fix mismatch of the model and html on render_html by @pedrobslisboa in ml-in-barcelona/server-reason-react#305 * Fix createFromFetch interface and avoid transition on navigation by @davesnx in ml-in-barcelona/server-reason-react#299 * Change ppx execution order (styles expansion in server-reason-react) by @davesnx in ml-in-barcelona/server-reason-react#297 * Rename use function to usePromise in Experimental module by @pedrobslisboa in ml-in-barcelona/server-reason-react#298 * Add shared-folder-prefix arg to ppx by @davesnx in ml-in-barcelona/server-reason-react#294
pedrobslisboa
added a commit
that referenced
this pull request
Dec 1, 2025
* origin/main: Add upper bound to quickjs 0.2.0 Only run this tests on 5.2.0 Bump lwt lower to 5.9.2 Fix docker Fix CI with hardocded value Specify version in dune-release-action Prepare 0.4.0 Use 0.27.0 Update ocamlformat 0.28.1 Update melange-fetch to 0.2.0 Ensure render_model always recieve a React.element feat: expand styles prop into className and style props with optional handling (#324) Lowercase components have ?key:string (#323)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the
stylesto work with both the' className' and' style' attributes.It also fixes an error on expanding
Optional "styles", before it was validating thefrtandsndvalues instead of thestylesitself. Now, we use anOption.mapto retrieve the correct values from the option content.File "packages/server-reason-react-ppx/test/test.re", line 631, characters 18-24: 631 | let div = <div ?styles />; ^^^^^^ Error: This expression has type 'a option but an expression was expected of type 'b * 'c Had 1 error, waiting for filesystem changes...Examples: