Skip to content

Commit 749fc40

Browse files
add useful comments based on joao
1 parent 24b2031 commit 749fc40

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

build/azure-pipelines/darwin/product-build-darwin.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ steps:
2222
displayName: Extract compilation output
2323
condition: and(succeeded(), ne(variables['VSCODE_ARCH'], 'universal'))
2424
25+
# Set up the credentials to retrieve distro repo and setup git persona
26+
# to create a merge commit for when we merge distro into oss
2527
- script: |
2628
set -e
2729
cat << EOF > ~/.netrc
@@ -119,6 +121,7 @@ steps:
119121
displayName: Rebuild native modules for ARM64
120122
condition: and(succeeded(), eq(variables['VSCODE_ARCH'], 'arm64'))
121123
124+
# This script brings in the right resources (images, icons, etc) based on the quality (insiders, stable, exploration)
122125
- script: |
123126
set -e
124127
node build/azure-pipelines/mixin
@@ -167,6 +170,9 @@ steps:
167170
displayName: Create Universal App
168171
condition: and(succeeded(), eq(variables['VSCODE_ARCH'], 'universal'))
169172
173+
# Setting hardened entitlements is a requirement for:
174+
# * Apple notarization
175+
# * Running tests on Big Sur (because Big Sur has additional security precautions)
170176
- script: |
171177
set -e
172178
security create-keychain -p pwd $(agent.tempdirectory)/buildagent.keychain

0 commit comments

Comments
 (0)