Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

[Cherry-pick] Filtering output files from luis:cross-train when encounter Composer … #1228

Merged
munozemilio merged 1 commit into from
Apr 29, 2021
Merged

[Cherry-pick] Filtering output files from luis:cross-train when encounter Composer … #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/luis/src/commands/luis/cross-train.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ export default class LuisCrossTrain extends Command {
validatedPath = utils.validatePath(fileId + fileExt, '', force)
}

await fs.writeFile(validatedPath, fileIdToLuResourceMap.get(fileId).Content, 'utf-8')
const composerSourceFileRegex = new RegExp(`[\\w-]+\\.source\\.([\\w-]+\\.)?${fileExt.substring(1)}`)
if (!composerSourceFileRegex.test(validatedPath)) {
await fs.writeFile(validatedPath, fileIdToLuResourceMap.get(fileId).Content, 'utf-8')
}
} catch (err) {
throw new CLIError(`Unable to write to file ${fileId}. Error: ${err.message}`)
}
Expand Down
1 change: 1 addition & 0 deletions packages/luis/test/commands/luis/crossTrain.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,5 +173,6 @@ describe('luis:cross-train tests for lu and qna contents', () => {
expect(await compareLuFiles('./../../../interruptionGen/ChitchatDialog.en-us.lu', './../../fixtures/verified/interruption9/ChitchatDialog.en-us.lu')).to.be.true
expect(await compareLuFiles('./../../../interruptionGen/ChitchatDialog.en-us.qna', './../../fixtures/verified/interruption9/ChitchatDialog.en-us.qna')).to.be.true
expect(fs.existsSync('./../../../interruptionGen/extra.en-us.lu')).to.be.false
expect(fs.existsSync('./../../../interruptionGen/chitchat_professional.source.en-us.qna')).to.be.false
})
})