Skip to content

Python: fix: use getattr for non-OpenAI provider response compatibility #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oxygen56 wants to merge 9 commits into
base: main
Choose a base branch
from
+7 −3
Open

Python: fix: use getattr for non-OpenAI provider response compatibility #6270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b35707c
fix: use getattr for non-OpenAI provider response compatibility
Oxygen56 Jun 2, 2026
e631d30
fix: use typed variable for response output to satisfy pyright
Oxygen56 Jun 3, 2026
0b870b8
fix: rename response_outputs to avoid name collision with case-block …
Oxygen56 Jun 3, 2026
22363c7
fix: use cast(list[Any]) for response output to satisfy pyright
Oxygen56 Jun 3, 2026
230c8a3
Merge branch 'main' into fix/issue-6234-6235
TaoChenOSU Jun 3, 2026
60fd2c8
fix: use hasattr guard instead of getattr for response.output
Oxygen56 Jun 4, 2026
cbefd8d
fix: use ternary operator for response_outputs assignment
Oxygen56 Jun 4, 2026
79f14ff
fix: use ternary with cast for ruff SIM108 and pyright type safety
Oxygen56 Jun 4, 2026
9be16c3
fix: replace hasattr+cast with try/except to preserve pyright types
Oxygen56 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion python/packages/openai/agent_framework_openai/_chat_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1971,7 +1971,11 @@ def _parse_response_from_openai(
metadata: dict[str, Any] = response.metadata or {}
contents: list[Content] = []
local_shell_tool_name = self._get_local_shell_tool_name(options.get("tools"))
for item in response.output: # type: ignore[reportUnknownMemberType]
try:
response_outputs = response.output # type: ignore[reportUnknownMemberType]
except AttributeError:
response_outputs = []
for item in response_outputs: # type: ignore[reportUnknownVariableType]
match item.type:
# types:
# ParsedResponseOutputMessage[Unknown] |
Expand Down
4 changes: 2 additions & 2 deletions python/packages/openai/agent_framework_openai/_chat_completion_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,13 +788,13 @@ def _parse_text_from_openai(self, choice: Choice | ChunkChoice) -> Content | Non
def _get_metadata_from_chat_response(self, response: ChatCompletion) -> dict[str, Any]:
"""Get metadata from a chat response."""
return {
"system_fingerprint": response.system_fingerprint,
"system_fingerprint": getattr(response, "system_fingerprint", None),
Comment thread
eavanvalkenburg marked this conversation as resolved.
}

def _get_metadata_from_streaming_chat_response(self, response: ChatCompletionChunk) -> dict[str, Any]:
"""Get metadata from a streaming chat response."""
return {
"system_fingerprint": response.system_fingerprint,
"system_fingerprint": getattr(response, "system_fingerprint", None),
Comment thread
eavanvalkenburg marked this conversation as resolved.
}

def _get_metadata_from_chat_choice(self, choice: Choice | ChunkChoice) -> dict[str, Any]:
Expand Down