Ensure ArchiveAsync methods don't return until the input channel is closed.

Having the ArciveAsync methods return after an error causes a
potential deadlock as users send into the jobs channel but there is no
goroutine listening.

Author: ncw

interfaces.go

@@ -77,8 +77,7 @@ type ArchiverAsync interface {
 	// the files for the archive. Close the files channel after
 	// all the files have been sent.
 	//
-	// This won't return until either an error has been reported
-	// (if not using ContinueOnError) or the channel is closed.
+	// This won't return until the channel is closed.
 	ArchiveAsync(ctx context.Context, output io.Writer, files <-chan ArchiveAsyncJob) error
 }
 

tar.go

@@ -63,15 +63,7 @@ func (t Tar) ArchiveAsync(ctx context.Context, output io.Writer, jobs <-chan Arc
 	defer tw.Close()
 
 	for job := range jobs {
-		err := t.writeFileToArchive(ctx, tw, job.File)
-		job.Result <- err
-		if err != nil {
-			if t.ContinueOnError && ctx.Err() == nil { // context errors should always abort
-				log.Printf("[ERROR] %v", err)
-				continue
-			}
-			return err
-		}
+		job.Result <- t.writeFileToArchive(ctx, tw, job.File)
 	}
 
 	return nil

zip.go

@@ -120,15 +120,7 @@ func (z Zip) ArchiveAsync(ctx context.Context, output io.Writer, jobs <-chan Arc
 
 	var i int
 	for job := range jobs {
-		err := z.archiveOneFile(ctx, zw, i, job.File)
-		job.Result <- err
-		if err != nil {
-			if z.ContinueOnError && ctx.Err() == nil { // context errors should always abort
-				log.Printf("[ERROR] %v", err)
-				continue
-			}
-			return err
-		}
+		job.Result <- z.archiveOneFile(ctx, zw, i, job.File)
 		i++
 	}