Skip to content

ci: fetch data plan on release build#46

Merged
alexs-mparticle merged 13 commits into
developmentfrom
ci/add-data-plan-fetch
May 2, 2022
Merged

ci: fetch data plan on release build#46
alexs-mparticle merged 13 commits into
developmentfrom
ci/add-data-plan-fetch

Conversation

@alexs-mparticle
Copy link
Copy Markdown
Contributor

@alexs-mparticle alexs-mparticle commented Apr 21, 2022 •
edited
Loading

Summary

  • Adding an action that uses a Data Plan Fetch Reusable Workflow will fetch the current data plan and opens a draft pull request against development.
  • This will be a "push button" action for the time being as Data Plans will not update frequently enough to warrant frequent polling.

Master Issue

Closes https://go.mparticle.com/work/SQDSDKS-3683

@alexs-mparticle alexs-mparticle marked this pull request as ready for review April 21, 2022 18:32
mchuangatmp
mchuangatmp suggested changes Apr 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mchuangatmp mchuangatmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add the GPG step when committing so it's verified.

Also i am leaning toward we not put this work in the release yaml and into a separate daily yaml file

@alexs-mparticle
Copy link
Copy Markdown
Contributor Author

alexs-mparticle commented Apr 21, 2022

I agree with the GPG, but I'm not sure about the Daily Check. Data plans don't upgrade frequently and since we're not validating, it feels excessive to check on a daily basis.

@alexs-mparticle alexs-mparticle force-pushed the ci/add-data-plan-fetch branch from a2e2135 to 7af24eb Compare April 28, 2022 22:25
mchuangatmp
mchuangatmp reviewed May 2, 2022
View reviewed changes
Comment thread .github/workflows/sync-higgs-shop-data-plan.yml Outdated
- name: Create Commit if Data Plan Changed
uses: stefanzweifel/git-auto-commit-action@v4
with:
commit_message: Update Higgs Shop Data Plan
Copy link
Copy Markdown
Contributor

@mchuangatmp mchuangatmp May 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd add our semantic version prefix here...looks like it'll be chore: update Higgs Shop data plan

Copy link
Copy Markdown
Contributor Author

@alexs-mparticle alexs-mparticle May 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Should it be chore?

mchuangatmp
mchuangatmp reviewed May 2, 2022
View reviewed changes
Comment thread .github/workflows/sync-higgs-shop-data-plan.yml
mchuangatmp
mchuangatmp approved these changes May 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mchuangatmp mchuangatmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to squash and merge

@alexs-mparticle alexs-mparticle merged commit 8e77465 into development May 2, 2022
@alexs-mparticle alexs-mparticle deleted the ci/add-data-plan-fetch branch May 2, 2022 15:42
@mparticle-automation
Copy link
Copy Markdown
Collaborator

mparticle-automation commented May 2, 2022

🎉 This PR is included in version 0.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willpassidomo willpassidomo Awaiting requested review from willpassidomo

1 more reviewer

@mchuangatmp mchuangatmp mchuangatmp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexs-mparticle @mparticle-automation @mchuangatmp