Skip to content

Commit 5875b9c

Browse files
authored
Merge pull request #31 from tisnik/logging-improvement
Logging improvement
2 parents 1a24182 + 3c14c5d commit 5875b9c

4 files changed

Lines changed: 28 additions & 4 deletions

File tree

src/app/main.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
from fastapi import FastAPI
22
from app import routers
33
import version
4+
import logging
5+
from log import get_logger
6+
7+
8+
logger = get_logger(__name__)
9+
10+
11+
logger.info("Initializing app")
412

513
app = FastAPI(
614
title="Lightspeed-core service - OpenAPI",
@@ -12,4 +20,10 @@
1220
},
1321
)
1422

23+
logger.info("Including routers")
1524
routers.include_routers(app)
25+
26+
27+
@app.on_event("startup")
28+
async def startup_event():
29+
get_logger("app.endpoints.handlers")

src/lightspeed-stack.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,9 @@
99

1010
FORMAT = "%(message)s"
1111
logging.basicConfig(
12-
level="NOTSET", format=FORMAT, datefmt="[%X]", handlers=[RichHandler()]
13-
) # set level=20 or logging.INFO to turn off debug
14-
logger = logging.getLogger("rich")
12+
level="INFO", format=FORMAT, datefmt="[%X]", handlers=[RichHandler()]
13+
)
1514

16-
logging.basicConfig(level=logging.INFO)
1715
logger = logging.getLogger(__name__)
1816

1917
if __name__ == "__main__":

src/log.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import logging
2+
from rich.logging import RichHandler
3+
4+
5+
def get_logger(name):
6+
logger = logging.getLogger(name)
7+
logger.setLevel(logging.DEBUG)
8+
logger.handlers = [RichHandler()]
9+
logger.propagate = False
10+
return logger

src/runners/uvicorn.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,6 @@ def start_uvicorn() -> None:
2222
port=port,
2323
workers=workers,
2424
log_level=log_level,
25+
use_colors=True,
26+
access_log=True,
2527
)

0 commit comments

Comments
 (0)