Skip to content

Commit 0ac867a

Browse files
committed
LCORE-739: added return type to unit tests
1 parent 491b29b commit 0ac867a

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

tests/unit/metrics/test_utis.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from metrics.utils import setup_model_metrics, update_llm_token_count_from_turn
44

55

6-
async def test_setup_model_metrics(mocker):
6+
async def test_setup_model_metrics(mocker) -> None:
77
"""Test the setup_model_metrics function."""
88

99
# Mock the LlamaStackAsLibraryClient
@@ -76,7 +76,7 @@ async def test_setup_model_metrics(mocker):
7676
)
7777

7878

79-
def test_update_llm_token_count_from_turn(mocker):
79+
def test_update_llm_token_count_from_turn(mocker) -> None:
8080
"""Test the update_llm_token_count_from_turn function."""
8181
mocker.patch("metrics.utils.Tokenizer.get_instance")
8282
mock_formatter_class = mocker.patch("metrics.utils.ChatFormat")

tests/unit/utils/test_common.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919

2020
@pytest.mark.asyncio
21-
async def test_register_mcp_servers_empty_list(mocker):
21+
async def test_register_mcp_servers_empty_list(mocker) -> None:
2222
"""Test register_mcp_servers with empty MCP servers list."""
2323
# Mock the logger
2424
mock_logger = Mock(spec=Logger)
@@ -49,7 +49,7 @@ async def test_register_mcp_servers_empty_list(mocker):
4949

5050

5151
@pytest.mark.asyncio
52-
async def test_register_mcp_servers_single_server_not_registered(mocker):
52+
async def test_register_mcp_servers_single_server_not_registered(mocker) -> None:
5353
"""Test register_mcp_servers with single MCP server that is not yet registered."""
5454
# Mock the logger
5555
mock_logger = Mock(spec=Logger)
@@ -94,7 +94,7 @@ async def test_register_mcp_servers_single_server_not_registered(mocker):
9494

9595

9696
@pytest.mark.asyncio
97-
async def test_register_mcp_servers_single_server_already_registered(mocker):
97+
async def test_register_mcp_servers_single_server_already_registered(mocker) -> None:
9898
"""Test register_mcp_servers with single MCP server that is already registered."""
9999
# Mock the logger
100100
mock_logger = Mock(spec=Logger)
@@ -132,7 +132,7 @@ async def test_register_mcp_servers_single_server_already_registered(mocker):
132132

133133

134134
@pytest.mark.asyncio
135-
async def test_register_mcp_servers_multiple_servers_mixed_registration(mocker):
135+
async def test_register_mcp_servers_multiple_servers_mixed_registration(mocker) -> None:
136136
"""Test register_mcp_servers with multiple MCP servers - some registered, some not."""
137137
# Mock the logger
138138
mock_logger = Mock(spec=Logger)
@@ -194,7 +194,7 @@ async def test_register_mcp_servers_multiple_servers_mixed_registration(mocker):
194194

195195

196196
@pytest.mark.asyncio
197-
async def test_register_mcp_servers_with_custom_provider(mocker):
197+
async def test_register_mcp_servers_with_custom_provider(mocker) -> None:
198198
"""Test register_mcp_servers with MCP server using custom provider."""
199199
# Mock the logger
200200
mock_logger = Mock(spec=Logger)
@@ -235,7 +235,7 @@ async def test_register_mcp_servers_with_custom_provider(mocker):
235235

236236

237237
@pytest.mark.asyncio
238-
async def test_register_mcp_servers_async_with_library_client(mocker):
238+
async def test_register_mcp_servers_async_with_library_client(mocker) -> None:
239239
"""
240240
Test that `register_mcp_servers_async` correctly registers MCP
241241
servers when using the library client configuration.

0 commit comments

Comments
 (0)