f: rename steps to sound like actions

Author: joostjager

.github/workflows/build.yml

@@ -90,58 +90,58 @@ jobs:
             echo "ELECTRS_EXE=$( pwd )/bin/electrs-${{ runner.os }}-${{ runner.arch }}" >> "$GITHUB_ENV"
       - name: Check workspace (except lightning-transaction-sync)
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh workspace-check
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh check-workspace
       - name: Test workspace (except lightning-transaction-sync)
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh workspace-tests
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-workspace
       - name: Test upgrade from prior LDK versions
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh ldk-upgrade-tests
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-ldk-upgrade
       - name: Check and build docs for workspace members
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh workspace-member-checks
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-workspace-members
       - name: Test lightning with dnssec feature
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh lightning-dnssec
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-lightning-dnssec
       - name: Test Block Sync Clients with features
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh lightning-block-sync-tests
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-lightning-block-sync
       - name: Check Transaction Sync Clients
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh lightning-transaction-sync-checks
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh check-lightning-transaction-sync
       - name: Test Transaction Sync Clients
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh lightning-transaction-sync-tests
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-lightning-transaction-sync
       - name: Test lightning-persister with tokio
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh lightning-persister-tests
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-lightning-persister
       - name: Test Custom Message Macros
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh lightning-custom-message-tests
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-lightning-custom-message
       - name: Test backtrace-debug builds
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh lightning-backtrace
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-lightning-backtrace
       - name: Test no_std builds
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh no-std-tests
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-no-std
       - name: Test c_bindings builds
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh c-bindings-tests
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-c-bindings
       - name: Test other crate-specific builds
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh other-crate-specific
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-crate-specific
       - name: Check no_std downstream crate
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh no-std-check
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh check-no-std
       - name: Check MSRV with release pins only
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh msrv-no-dev-deps-check
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh check-msrv-no-dev-deps
       - name: Build no_std for ARM Embedded
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh no-std-check-arm
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh check-no-std-arm
       - name: Test cfg-flag builds
         shell: bash
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh cfg-flag-tests
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh test-cfg-flags
 
   coverage:
     needs: fuzz

ci/ci-tests.sh

@@ -26,24 +26,24 @@ export RUST_BACKTRACE=1
 
 # All steps in order, matching the original script flow
 ALL_STEPS="
-workspace-check
-workspace-tests
-ldk-upgrade-tests
-workspace-member-checks
-lightning-dnssec
-lightning-block-sync-tests
-lightning-transaction-sync-checks
-lightning-transaction-sync-tests
-lightning-persister-tests
-lightning-custom-message-tests
-lightning-backtrace
-no-std-tests
-c-bindings-tests
-other-crate-specific
-no-std-check
-msrv-no-dev-deps-check
-no-std-check-arm
-cfg-flag-tests
+check-workspace
+test-workspace
+test-ldk-upgrade
+test-workspace-members
+test-lightning-dnssec
+test-lightning-block-sync
+check-lightning-transaction-sync
+test-lightning-transaction-sync
+test-lightning-persister
+test-lightning-custom-message
+test-lightning-backtrace
+test-no-std
+test-c-bindings
+test-crate-specific
+check-no-std
+check-msrv-no-dev-deps
+check-no-std-arm
+test-cfg-flags
 "
 
 # If a step name is passed, run just that step. Otherwise run all.
@@ -58,39 +58,39 @@ WORKSPACE_MEMBERS=( $(cat Cargo.toml | tr '\n' '\r' | sed 's/\r    //g' | tr '\r
 for STEP in $STEPS_TO_RUN; do
 case "$STEP" in
 
-workspace-check)
+check-workspace)
 echo -e "\n\nChecking the workspace, except lightning-transaction-sync."
 cargo check --verbose --color always
 ;;
 
-workspace-tests)
+test-workspace)
 echo -e "\n\nTesting the workspace, except lightning-transaction-sync."
 cargo test --verbose --color always
 ;;
 
-ldk-upgrade-tests)
+test-ldk-upgrade)
 echo -e "\n\nTesting upgrade from prior versions of LDK"
 pushd lightning-tests
 cargo test
 popd
 ;;
 
-workspace-member-checks)
+test-workspace-members)
 echo -e "\n\nChecking and building docs for all workspace members individually..."
 for DIR in "${WORKSPACE_MEMBERS[@]}"; do
 	cargo check -p "$DIR" --verbose --color always
 	cargo doc -p "$DIR" --document-private-items
 done
 ;;
 
-lightning-dnssec)
+test-lightning-dnssec)
 echo -e "\n\nChecking and testing lightning with features"
 cargo test -p lightning --verbose --color always --features dnssec
 cargo check -p lightning --verbose --color always --features dnssec
 cargo doc -p lightning --document-private-items --features dnssec
 ;;
 
-lightning-block-sync-tests)
+test-lightning-block-sync)
 echo -e "\n\nChecking and testing Block Sync Clients with features"
 
 cargo test -p lightning-block-sync --verbose --color always --features rest-client
@@ -103,15 +103,15 @@ cargo test -p lightning-block-sync --verbose --color always --features rpc-clien
 cargo check -p lightning-block-sync --verbose --color always --features rpc-client,rest-client,tokio
 ;;
 
-lightning-transaction-sync-checks)
+check-lightning-transaction-sync)
 echo -e "\n\nChecking Transaction Sync Clients with features."
 cargo check -p lightning-transaction-sync --verbose --color always --features esplora-blocking
 cargo check -p lightning-transaction-sync --verbose --color always --features esplora-async
 cargo check -p lightning-transaction-sync --verbose --color always --features esplora-async-https
 cargo check -p lightning-transaction-sync --verbose --color always --features electrum
 ;;
 
-lightning-transaction-sync-tests)
+test-lightning-transaction-sync)
 if [ -z "$CI_ENV" ] && [[ -z "$BITCOIND_EXE" || -z "$ELECTRS_EXE" ]]; then
 	echo -e "\n\nSkipping testing Transaction Sync Clients due to BITCOIND_EXE or ELECTRS_EXE being unset."
 	cargo check -p lightning-transaction-sync --tests
@@ -124,25 +124,25 @@ else
 fi
 ;;
 
-lightning-persister-tests)
+test-lightning-persister)
 echo -e "\n\nChecking and testing lightning-persister with features"
 cargo test -p lightning-persister --verbose --color always --features tokio
 cargo check -p lightning-persister --verbose --color always --features tokio
 cargo doc -p lightning-persister --document-private-items --features tokio
 ;;
 
-lightning-custom-message-tests)
+test-lightning-custom-message)
 echo -e "\n\nTest Custom Message Macros"
 cargo test -p lightning-custom-message --verbose --color always
 [ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
 ;;
 
-lightning-backtrace)
+test-lightning-backtrace)
 echo -e "\n\nTest backtrace-debug builds"
 cargo test -p lightning --verbose --color always --features backtrace
 ;;
 
-no-std-tests)
+test-no-std)
 echo -e "\n\nTesting no_std builds"
 for DIR in lightning-invoice lightning-rapid-gossip-sync lightning-liquidity; do
 	cargo test -p $DIR --verbose --color always --no-default-features
@@ -152,7 +152,7 @@ cargo test -p lightning --verbose --color always --no-default-features
 cargo test -p lightning-background-processor --verbose --color always --no-default-features
 ;;
 
-c-bindings-tests)
+test-c-bindings)
 echo -e "\n\nTesting c_bindings builds"
 # Note that because `$RUSTFLAGS` is not passed through to doctest builds we cannot selectively
 # disable doctests in `c_bindings` so we skip doctests entirely here.
@@ -169,7 +169,7 @@ RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p lightning-background-proce
 RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p lightning --verbose --color always --no-default-features --lib --bins --tests
 ;;
 
-other-crate-specific)
+test-crate-specific)
 echo -e "\n\nTesting other crate-specific builds"
 # Note that outbound_commitment_test only runs in this mode because of hardcoded signature values
 RUSTFLAGS="$RUSTFLAGS --cfg=ldk_test_vectors" cargo test -p lightning --verbose --color always --no-default-features --features=std
@@ -178,7 +178,7 @@ RUSTFLAGS="$RUSTFLAGS --cfg=ldk_test_vectors" cargo test -p lightning --verbose
 cargo test -p lightning-invoice --verbose --color always --no-default-features --features serde
 ;;
 
-no-std-check)
+check-no-std)
 echo -e "\n\nTesting no_std build on a downstream no-std crate"
 # check no-std compatibility across dependencies
 pushd no-std-check
@@ -187,7 +187,7 @@ cargo check --verbose --color always
 popd
 ;;
 
-msrv-no-dev-deps-check)
+check-msrv-no-dev-deps)
 # Test that we can build downstream code with only the "release pins".
 pushd msrv-no-dev-deps-check
 PIN_RELEASE_DEPS
@@ -196,7 +196,7 @@ cargo check
 popd
 ;;
 
-no-std-check-arm)
+check-no-std-arm)
 if [ -f "$(which arm-none-eabi-gcc)" ]; then
 	pushd no-std-check
 	cargo build --target=thumbv7m-none-eabi
@@ -205,7 +205,7 @@ if [ -f "$(which arm-none-eabi-gcc)" ]; then
 fi
 ;;
 
-cfg-flag-tests)
+test-cfg-flags)
 echo -e "\n\nTest cfg-flag builds"
 RUSTFLAGS="--cfg=taproot" cargo test --verbose --color always -p lightning
 [ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean