Commit caaba21
committed
Correct Channel outbound HTLC serialization
Channel serialization should happen "as if
remove_uncommitted_htlcs_and_mark_paused had just been called".
This is true for the most part, but outbound RemoteRemoved HTLCs
were being serialized as normal, even though
`remote_uncommitted_htlcs_and_mark_paused` resets them to
`Committed`.
This led to a bug identified by the `chanmon_consistency_target`
fuzzer wherein, if we receive a update_*_htlc message bug not the
corresponding commitment_signed prior to a serialization roundtrip,
we'd force-close the channel due to the peer "attempting to
fail/claim an HTLC which was already failed/claimed".1 parent 779c752 commit caaba21
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4425 | 4425 | | |
4426 | 4426 | | |
4427 | 4427 | | |
4428 | | - | |
4429 | | - | |
4430 | | - | |
| 4428 | + | |
| 4429 | + | |
| 4430 | + | |
| 4431 | + | |
4431 | 4432 | | |
4432 | 4433 | | |
4433 | 4434 | | |
| |||
0 commit comments