Skip to content

Apply PHP 8.0 Syntax and constructor promotion #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ocramius merged 1 commit into from
Jan 9, 2023
Merged

Apply PHP 8.0 Syntax and constructor promotion #23

Ocramius merged 1 commit into from
Jan 9, 2023

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 9, 2023

Q A
QA yes

Description

Since composer.json require php 8.0, php 8.0 syntax can constuctor promotion can be applied.

@samsonasik
Copy link
Member Author

samsonasik commented Jan 9, 2023

All green 🎉

Ocramius
Ocramius approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samsonasik!

@Ocramius Ocramius self-assigned this Jan 9, 2023
@Ocramius Ocramius added the Enhancement New feature or request label Jan 9, 2023
@Ocramius Ocramius added this to the 1.7.0 milestone Jan 9, 2023
@Ocramius Ocramius merged commit aa1b606 into laminas-api-tools:1.7.x Jan 9, 2023
@samsonasik samsonasik deleted the apply-php80 branch January 9, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels

Enhancement New feature or request

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @Ocramius