Skip to content

Fix bootpd check on macOS >= 15 #20400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
medyagh merged 1 commit into from
Feb 11, 2025
Merged

Fix bootpd check on macOS >= 15 #20400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/minikube/firewall/firewall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ func IsBootpdBlocked(cc config.ClusterConfig) bool {
if regexp.MustCompile(`Firewall is disabled`).Match(out) {
return false
}
out, err = exec.Command("/usr/libexec/ApplicationFirewall/socketfilterfw", "--getallowsigned").Output()
if err != nil {
// macOS < 15 or other issue: need to use --list.
klog.Warningf("failed to list firewall allowedsinged option: %v", err)
} else {
// macOS >= 15: bootpd may be allowed as builtin software.
if regexp.MustCompile(`Automatically allow built-in signed software ENABLED`).Match(out) {
return false
}
}
out, err = exec.Command("/usr/libexec/ApplicationFirewall/socketfilterfw", "--listapps").Output()
if err != nil {
klog.Warningf("failed to list firewall apps: %v", err)
Expand Down