Skip to content

Conversation

@dezmodue
Copy link
Contributor

@dezmodue dezmodue commented Dec 5, 2025

As discussed yesterday during the kOps meeting - this patch makes sure that the kubelet systemd unit is not enabled by nodeup during the warming phase. This helps for use cases where a reboot is needed during the warming up phase and systemd would start the kubelet after reboot causing the node to join the cluster before the warming lifecycle is completed.

Ping @justinsb as requested

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dezmodue. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from zetaab December 5, 2025 13:57
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2025
@hakman
Copy link
Member

hakman commented Dec 5, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2025
@hakman hakman changed the title WIP - Nodeup: do not enable the kubelet systemd unit during Warming lifecycle (warm pool) WIP - aws: Disable the kubelet systemd unit during warm pool warming Dec 5, 2025
@hakman
Copy link
Member

hakman commented Dec 8, 2025

/test pull-kops-e2e-cni-amazonvpc
/test pull-kops-e2e-k8s-aws-amazonvpc

@hakman
Copy link
Member

hakman commented Dec 8, 2025

@dezmodue did you get a chance to test this on a test cluster with your setup?

@dezmodue
Copy link
Contributor Author

dezmodue commented Dec 8, 2025

@hakman we are about to test it - I will report back

@hakman
Copy link
Member

hakman commented Dec 8, 2025

@hakman we are about to test it - I will report back

If you want to use the build from this PR, you can look into the build log for KOPS_BASE_URL.
You just need to build the kops binary and export KOPS_BASE_URL=....
Clusters will be created with the binaries from KOPS_BASE_URL.

@hakman
Copy link
Member

hakman commented Dec 8, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants