-
Notifications
You must be signed in to change notification settings - Fork 4.7k
WIP - aws: Disable the kubelet systemd unit during warm pool warming #17792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @dezmodue. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/test pull-kops-e2e-cni-amazonvpc |
|
@dezmodue did you get a chance to test this on a test cluster with your setup? |
|
@hakman we are about to test it - I will report back |
If you want to use the build from this PR, you can look into the build log for |
|
/retest |
As discussed yesterday during the kOps meeting - this patch makes sure that the kubelet systemd unit is not enabled by nodeup during the warming phase. This helps for use cases where a reboot is needed during the warming up phase and systemd would start the kubelet after reboot causing the node to join the cluster before the warming lifecycle is completed.
Ping @justinsb as requested