Add contextual logging to controllers #323
Conversation
This adds contextual logging only to our controller classes to help differentiate the logging coming from each. For now it is limited to the `controller.go` files since those are the key conflicting filenames in the log output. To switch entirely over to contextual logging as a whole will require more intrusive changes, so this just addresses are major pain point for now. Signed-off-by: Sean McGinnis <[email protected]>
|
@stmcginnis: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, stmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds contextual logging only to our controller classes to help differentiate the logging coming from each. For now it is limited to the
controller.gofiles since those are the key conflicting filenames in the log output. To switch entirely over to contextual logging as a whole will require more intrusive changes, so this just addresses are major pain point for now.Closes: #313