Skip to content

Conversation

@rajib76
Copy link

@rajib76 rajib76 commented Jun 15, 2024

The code can be further optimized by reducing some of the hardcodings. In this pull request, i moved the user to .env. I plan to look at some more areas to improve and create a pull request for the same.

README.md Outdated
```
OPENAI_API_KEY="YOUR_API_KEY"
NEO4J_PW="YOUR_NEO4J_PW"
NEO4J_USER="YOUR_NEO4J_PW"
Copy link
Owner

@kingjulio8238 kingjulio8238 Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this simple addition - added flexibility is great but please edit line 56 accordingly: would need to be NEO4J_USER=YOUR_NEO4J_USERNAME.

@kingjulio8238
Copy link
Owner

@rajib76 thanks for the request to make memary more flexible. It would be great to fix any more existing hardcodings within this PR!

@rajib76
Copy link
Author

rajib76 commented Jun 15, 2024

I have added the commit to fix the typo in README. Can this now be merged? I will need some time to look at the rest of the hardcoding, it may require a little more coding. For example thinking to create a graphmemorystore class so that we give flexibility to users to use any type of graph db and not just NEO4J. Currently the KG supports only NEO4J.

@rajib76
Copy link
Author

rajib76 commented Jun 16, 2024

Added the NEO4J_DB also in .env. With this I think I have taken care of most of the hard codings. There are other opportunities to optimize the code which will do slowly

@kingjulio8238
Copy link
Owner

@rajib76 Agreed, It would be great to expand support to other graph providers! Once you have finished with that update this PR and we'll merge the contribution.

Thanks again! Excited to see updates

@rajib76
Copy link
Author

rajib76 commented Jun 17, 2024

Added the forgetting feature using ebbinghaus law

@kingjulio8238 kingjulio8238 changed the title Neo4j user was harcoded. Moved that to .env Memory Retention Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants