-
Notifications
You must be signed in to change notification settings - Fork 187
Memory Retention #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Memory Retention #46
Conversation
README.md
Outdated
| ``` | ||
| OPENAI_API_KEY="YOUR_API_KEY" | ||
| NEO4J_PW="YOUR_NEO4J_PW" | ||
| NEO4J_USER="YOUR_NEO4J_PW" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this simple addition - added flexibility is great but please edit line 56 accordingly: would need to be NEO4J_USER=YOUR_NEO4J_USERNAME.
|
@rajib76 thanks for the request to make memary more flexible. It would be great to fix any more existing hardcodings within this PR! |
|
I have added the commit to fix the typo in README. Can this now be merged? I will need some time to look at the rest of the hardcoding, it may require a little more coding. For example thinking to create a graphmemorystore class so that we give flexibility to users to use any type of graph db and not just NEO4J. Currently the KG supports only NEO4J. |
|
Added the NEO4J_DB also in .env. With this I think I have taken care of most of the hard codings. There are other opportunities to optimize the code which will do slowly |
|
@rajib76 Agreed, It would be great to expand support to other graph providers! Once you have finished with that update this PR and we'll merge the contribution. Thanks again! Excited to see updates |
|
Added the forgetting feature using ebbinghaus law |
The code can be further optimized by reducing some of the hardcodings. In this pull request, i moved the user to .env. I plan to look at some more areas to improve and create a pull request for the same.