Skip to content

Commit 85494cf

Browse files
steffen-maiergregkh
authored andcommitted
scsi: zfcp: fix missing zfcp_port reference put on -EBUSY from port_remove
commit d27e5e0 upstream. With this early return due to zfcp_unit child(ren), we don't use the zfcp_port reference from the earlier zfcp_get_port_by_wwpn() anymore and need to put it. Signed-off-by: Steffen Maier <maier@linux.ibm.com> Fixes: d99b601 ("[SCSI] zfcp: restore refcount check on port_remove") Cc: <stable@vger.kernel.org> #3.7+ Reviewed-by: Jens Remus <jremus@linux.ibm.com> Reviewed-by: Benjamin Block <bblock@linux.ibm.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 701d744 commit 85494cf

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/s390/scsi/zfcp_sysfs.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ static ssize_t zfcp_sysfs_port_remove_store(struct device *dev,
263263
if (atomic_read(&port->units) > 0) {
264264
retval = -EBUSY;
265265
mutex_unlock(&zfcp_sysfs_port_units_mutex);
266+
put_device(&port->dev); /* undo zfcp_get_port_by_wwpn() */
266267
goto out;
267268
}
268269
/* port is about to be removed, so no more unit_add */

0 commit comments

Comments
 (0)