Always use run_tpu_tests label to run TPU tests.
#21900
Draft
+35
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
run_tpu_tests label to run the TPU tests.run_tpu_tests label to run Gemma.
run_tpu_tests label to run Gemma.run_tpu_tests label to run TPU tests.
1e37b61 to
51c59c8
Compare
divyashreepathihalli
previously approved these changes
Dec 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21900 +/- ##
==========================================
+ Coverage 76.27% 76.30% +0.02%
==========================================
Files 579 579
Lines 59917 59950 +33
Branches 9403 9410 +7
==========================================
+ Hits 45703 45744 +41
+ Misses 11748 11738 -10
- Partials 2466 2468 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
51c59c8 to
83943fd
Compare
divyashreepathihalli
previously approved these changes
Dec 5, 2025
83943fd to
694a124
Compare
run_tpu_tests label to run TPU tests.run_tpu_tests label to run Gemma tests.
run_tpu_tests label to run Gemma tests.run_tpu_tests label to run TPU tests.
divyashreepathihalli
previously approved these changes
Dec 5, 2025
694a124 to
1b5e9e6
Compare
divyashreepathihalli
previously approved these changes
Dec 5, 2025
Problem: the current approach creates two entries for TPU tests: one for `pull_request` and one for `pull_request_review`. But we only want one entry and one run of the tests. Solution: add a new labeler workflow to label the PR on approval, which in turn triggers the TPU tests. Also rename `welcome` workflow.
1b5e9e6 to
2ff0711
Compare
divyashreepathihalli
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the current approach creates two entries for TPU tests: one for
pull_requestand one forpull_request_review. But we only want one entry and one run of the tests.Solution: add a new labeler workflow to label the PR on approval, which in turn triggers the TPU tests.
lso rename
welcomeworkflow.