Skip to content

Conversation

@ashmaroli
Copy link
Member

Apart from simplifying the render() function, there are some other changes included in this proposal:

  • MetaButtons now use an internal state to determine the dropdown visibility — the class no longer uses props onDropdownFocus and onDropdownBlur to toggle showing-dropdown className on the parent wrapper — the class is attached to the dropdown trigger button itself.
  • The dropdown trigger toggles dropdown visibility — the dropdown gets hidden on both clicking the focused trigger and on the trigger losing focus.

Copy link
Member

@mertkahyaoglu mertkahyaoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one 👍

@ashmaroli ashmaroli merged commit 8d3debc into jekyll:master Dec 2, 2019
@ashmaroli ashmaroli deleted the refactor-metabuttons branch December 6, 2019 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants