Skip to content

Allow custom labels for collections in sidebar #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashmaroli merged 1 commit into from
Oct 14, 2019
Merged

Allow custom labels for collections in sidebar #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/containers/Sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class Sidebar extends Component {
to={`${ADMIN_PREFIX}/collections/${col.label}`}
>
<i className="fa fa-book" />
{capitalize(col.label)}
{col.sidebar_label || capitalize(col.label)}
</Link>
</li>
);
Expand Down
133 changes: 133 additions & 0 deletions src/containers/tests/__snapshots__/sidebar.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,139 @@ exports[`Containers::Sidebar renders correctly 1`] = `
</div>
`;

exports[`Containers::Sidebar renders with custom collection labels 1`] = `
<div
className="sidebar"
>
<a
className="logo"
onClick={[Function]}
style={Object {}}
/>
<ul
className="routes"
>
<li
className="accordion-label collapsed"
style={
Object {
"maxHeight": 50,
}
}
>
<a
onClick={[Function]}
>
<i
className="fa fa-book"
/>
Collections
<div
className="counter"
>
2
</div>
<div
className="chevrons"
>
<i
className="fa fa-chevron-up"
/>
</div>
</a>
<ul>
<li>
<a
onClick={[Function]}
style={Object {}}
>
<i
className="fa fa-book"
/>
Tutorials
</a>
</li>
<li>
<a
onClick={[Function]}
style={Object {}}
>
<i
className="fa fa-book"
/>
Docs
</a>
</li>
</ul>
</li>
<li>
<a
onClick={[Function]}
style={Object {}}
>
<i
className="fa fa-book"
/>
Posts
</a>
</li>
<div
className="splitter"
/>
<li>
<a
onClick={[Function]}
style={Object {}}
>
<i
className="fa fa-file-text"
/>
Pages
</a>
</li>
<div
className="splitter"
/>
<li>
<a
onClick={[Function]}
style={Object {}}
>
<i
className="fa fa-database"
/>
Data Files
</a>
</li>
<li>
<a
onClick={[Function]}
style={Object {}}
>
<i
className="fa fa-file"
/>
Static Files
</a>
</li>
<div
className="splitter"
/>
<li>
<a
onClick={[Function]}
style={Object {}}
>
<i
className="fa fa-cog"
/>
Configuration
</a>
</li>
</ul>
</div>
`;

exports[`Containers::Sidebar renders with zero collections 1`] = `
<div
className="sidebar"
Expand Down
18 changes: 18 additions & 0 deletions src/containers/tests/sidebar.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,24 @@ describe('Containers::Sidebar', () => {
expect(tree).toMatchSnapshot();
});

it('renders with custom collection labels', () => {
const props = {
...defaultProps,
collections: [
{
label: 'walkthroughs',
sidebar_label: 'Tutorials',
},
{
label: 'docs',
},
],
};

const tree = renderer.create(<Sidebar {...props} {...actions} />).toJSON();
expect(tree).toMatchSnapshot();
});

it('calls fetchCollections action after mounted', () => {
expect(actions.fetchCollections).toHaveBeenCalled();
});
Expand Down