Skip to content

applied "encodeURIComponent" to "branchName"#91

Merged
jdalrymple merged 1 commit into
jdalrymple:masterfrom
IKatsuba:bugfix/branch-name-encode
May 22, 2018
Merged

applied "encodeURIComponent" to "branchName"#91
jdalrymple merged 1 commit into
jdalrymple:masterfrom
IKatsuba:bugfix/branch-name-encode

Conversation

@IKatsuba

Copy link
Copy Markdown
Contributor

Solution for the problem

const projectId = 5;
const branchName = 'environment/test';

Branches.show(projectId, branchName);
StatusCodeError: 404 - {"error":"404 Not Found"}
    at new StatusCodeError (/project/node_modules/request-promise-core/lib/errors.js:32:15)
    at Request.plumbing.callback (/project/node_modules/request-promise-core/lib/plumbing.js:104:33)
    at Request.RP$callback [as _callback] (/project/node_modules/request-promise-core/lib/plumbing.js:46:31)
    at Request.self.callback (/project/node_modules/request/request.js:188:22)
    at emitTwo (events.js:126:13)
    at Request.emit (events.js:214:7)
    at Request.<anonymous> (/project/node_modules/request/request.js:1171:10)
    at emitOne (events.js:116:13)
    at Request.emit (events.js:211:7)
    at IncomingMessage.<anonymous> (/project/node_modules/request/request.js:1091:12)
    at Object.onceWrapper (events.js:313:30)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

@jdalrymple

Copy link
Copy Markdown
Owner

Looks good!

@jdalrymple jdalrymple merged commit 850b338 into jdalrymple:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants