doc: update os.markdown #976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM, except the commit message should start with |
Contributor
|
What @tellnes said. Otherwise LGTM. |
Member
Author
|
Thanks, I've renamed it appropriately. |
doc/api/os.markdown
Outdated
Member
Author
|
@brendanashworth thanks! Fixed and squashed. |
doc/api/os.markdown
Outdated
Some doc update based on improvement ideas I remember from when I used this module in node: - Mention windows returns 0 for `nice` values (which is obvious, but io makes no attempt to calculate something similar or return undefined, 0 is returned) - Mention platform and arch are aliases for `process` properties. - Document possible return values where appropriate, add examples in others. - Rename title in order to match other titles in the navigation. - Fix line that was over 80 characters long.
Member
Author
|
Thanks @vkurchatkin! I've changed the quoting per your suggestion - it's worth mentioning it's not consistent throughout the docs (discussed in Domenic's promise event docs PR) |
Contributor
|
LGTM |
tellnes
pushed a commit
that referenced
this pull request
Feb 27, 2015
Some doc update based on improvement ideas I remember from when I used this module in node: - Mention windows returns 0 for `nice` values (which is obvious, but io makes no attempt to calculate something similar or return undefined, 0 is returned) - Mention platform and arch are aliases for `process` properties. - Document possible return values where appropriate, add examples in others. - Rename title in order to match other titles in the navigation. - Fix line that was over 80 characters long. PR-URL: #976 Reviewed-By: Christian Tellnes <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Vladimir Kurchatkin <[email protected]>
Contributor
|
Landed as f83d380 |
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some doc update based on improvement ideas I remember from when I used this module in node:
nicevalues (which is obvious, but io makes no attempt to calculate something similar or return undefined, 0 is returned)processproperties.