Skip to content

Conversation

@hiqua
Copy link
Collaborator

@hiqua hiqua commented Oct 3, 2021

Follow-up from #1102, with comments addressed.

@kalina559 FYI, feel free to take things from there if you wish to continue, otherwise I'll try to get this merged.

@hiqua hiqua force-pushed the after_toggle_delay branch from 7beb792 to d72b811 Compare October 3, 2021 19:53
@hiqua hiqua requested a review from iSoron October 3, 2021 19:54
@hiqua hiqua marked this pull request as draft October 3, 2021 20:44
@hiqua hiqua force-pushed the after_toggle_delay branch 2 times, most recently from 660de66 to 3cbff9b Compare October 3, 2021 21:36
@hiqua
Copy link
Collaborator Author

hiqua commented Oct 3, 2021

If you have an opinion on the best way to avoid sleeping in these particular tests I can look into it.

@iSoron
Copy link
Owner

iSoron commented Oct 4, 2021

If you have an opinion on the best way to avoid sleeping in these particular tests I can look into it.

Just a random thought, but maybe we could use a multiple of some animation duration, instead of 2000 ms? AFAIK, during test, the duration of all animations are set to zero, so the delay would disappear. In any case, I don't think this is a big issue, since large tests are already very slow.

@hiqua
Copy link
Collaborator Author

hiqua commented Oct 5, 2021

Ok, val delay = 4 * context.resources.getInteger(android.R.integer.config_longAnimTime).toLong() could work, but it's not set to 0 during the test. Maybe I'll revisit at some other time, but if it's not a concern I'll just merge how it is now.

@hiqua hiqua marked this pull request as ready for review October 5, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants