Skip to content

Feature/DistinctStructFiles#34

Merged
hypfvieh merged 5 commits intohypfvieh:masterfrom
clearswift:feature/INNO-147
Dec 18, 2018
Merged

Feature/DistinctStructFiles#34
hypfvieh merged 5 commits intohypfvieh:masterfrom
clearswift:feature/INNO-147

Conversation

@sshort
Copy link
Copy Markdown
Contributor

@sshort sshort commented Dec 18, 2018

Potential fix for #33

  • Updated to create Struct files in Java package name that matches the object path. (Pushed down a level compared to the current implementation)
  • Added some logging and logback dependencies

@sshort sshort changed the title Feature/inno 147 Feature/DistinctStructFiles Dec 18, 2018
@hypfvieh
Copy link
Copy Markdown
Owner

Thanks for your PR.
The CreateInterface definitely needs some love - it's still in the same condition as it was in the original version of dbus-java.
I'm not using this tool, so I did not spend much time on improving it.

@hypfvieh hypfvieh merged commit 0d0c937 into hypfvieh:master Dec 18, 2018
@sshort
Copy link
Copy Markdown
Contributor Author

sshort commented Dec 19, 2018

FYI I don't think this is sufficient to fix the problem. It's broken with or without this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants