Skip to content

enh(cpp) simpler struct matching #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshgoebel merged 16 commits into from
Apr 13, 2021
Merged

enh(cpp) simpler struct matching #3078

joshgoebel merged 16 commits into from
Apr 13, 2021

Conversation

@joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Mar 26, 2021 •
edited
Loading

Resolves #2736. Resolves #2520. Resolves #3112.

Changes

Seems to do about as well as GitHub now.

Screen Shot 2021-03-26 at 12 39 58 PM

Checklist

  • Added markup tests, or they don't apply here because...
  • docs for beforeMatch
  • Updated the changelog at CHANGES.md

@joshgoebel joshgoebel marked this pull request as draft March 26, 2021 16:44
@joshgoebel joshgoebel mentioned this pull request Mar 26, 2021
Closed
@joshgoebel
Copy link
Member Author

joshgoebel commented Mar 26, 2021 •
edited
Loading

Right now I'm using .title-class... but I wonder if perhaps we shouldn't perhaps be a bit clearer (to add some separation between our existing class names that sometimes already use both - and _.

  • .title--class
  • .title__class

@joshgoebel joshgoebel force-pushed the cpp_struct_class_etc branch 2 times, most recently from f239ffe to 8cf00fe Compare March 27, 2021 23:21
@joshgoebel joshgoebel added this to the 11.0 alpha 1 milestone Mar 28, 2021
@joshgoebel joshgoebel force-pushed the cpp_struct_class_etc branch 2 times, most recently from 79025b1 to 80d5b9b Compare April 4, 2021 04:37
@joshgoebel
Copy link
Member Author

joshgoebel commented Apr 4, 2021

This is currently rebased on the multi-class stuff (so I could finish it), but in review that can be ignored.

@joshgoebel joshgoebel force-pushed the cpp_struct_class_etc branch from 80d5b9b to 55dd7a6 Compare April 4, 2021 05:57
@joshgoebel joshgoebel marked this pull request as ready for review April 4, 2021 05:57
@joshgoebel joshgoebel requested a review from allejo April 4, 2021 05:57
@joshgoebel joshgoebel mentioned this pull request Apr 4, 2021
Closed
@joshgoebel joshgoebel force-pushed the cpp_struct_class_etc branch 3 times, most recently from 33016b3 to 0394a55 Compare April 12, 2021 23:44
joshgoebel
joshgoebel commented Apr 12, 2021
View reviewed changes
Copy link
Member Author

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approving. @allejo If you have time to look at this later and see anything terrible please let me know.

@joshgoebel joshgoebel force-pushed the cpp_struct_class_etc branch 2 times, most recently from 1729d4f to 61777e0 Compare April 13, 2021 00:03
NullVoxPopuli
NullVoxPopuli reviewed Apr 13, 2021
View reviewed changes
NullVoxPopuli
NullVoxPopuli reviewed Apr 13, 2021
View reviewed changes
NullVoxPopuli
NullVoxPopuli reviewed Apr 13, 2021
View reviewed changes
NullVoxPopuli
NullVoxPopuli approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exciting! It'll make my own grammar cleaner in a few places :D

@joshgoebel joshgoebel force-pushed the cpp_struct_class_etc branch from 61777e0 to 73e60ee Compare April 13, 2021 00:28
@joshgoebel joshgoebel force-pushed the cpp_struct_class_etc branch from 73e60ee to e2d8ab5 Compare April 13, 2021 00:29
@joshgoebel joshgoebel merged commit e594e5a into highlightjs:main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allejo allejo Awaiting requested review from allejo

1 more reviewer

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@allejo allejo

Labels

None yet

Projects

None yet

Milestone

11.0 alpha 1

3 participants

@joshgoebel @NullVoxPopuli @allejo