From e027627a5d6dbf3aa30f724bbe68aabad1767c55 Mon Sep 17 00:00:00 2001
From: AyushShukla1807 <ayush.shukla@adypu.edu.in>
Date: Sat, 21 Mar 2026 18:00:26 +0530
Subject: [PATCH 1/5] Fix 500 error and CORS drop on empty round creation
 payloads

This commit patches the admin_endpoints validation to gracefully handle empty POST bodies, and modifies MessageMiddleware to intercept MontageErrors so they correctly return 400 Bad Request JSON instead of bypassing CORS headers. Resolves Issue #357.
---
 montage/admin_endpoints.py |  2 ++
 montage/mw/__init__.py     | 30 ++++++++++++++++++++----------
 2 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/montage/admin_endpoints.py b/montage/admin_endpoints.py
index a4f608d1..f2019c05 100644
--- a/montage/admin_endpoints.py
+++ b/montage/admin_endpoints.py
@@ -461,6 +461,8 @@ def cancel_campaign(user_dao, campaign_id):
 
 def _prepare_round_params(coord_dao, request_dict):
     rnd_dict = {}
+    if not request_dict:
+        request_dict = {}
     req_columns = ['jurors', 'name', 'vote_method', 'deadline_date']
     extra_columns = ['description', 'config', 'directions', 'show_stats']
     valid_vote_methods = ['ranking', 'rating', 'yesno']
diff --git a/montage/mw/__init__.py b/montage/mw/__init__.py
index 773c6723..bb3cc287 100644
--- a/montage/mw/__init__.py
+++ b/montage/mw/__init__.py
@@ -63,16 +63,26 @@ def endpoint(self, next, response_dict, request, _route):
         try:
             ret = next()
         except Exception as e:
-            if self.debug_errors and not isinstance(e, MontageError):
-                import pdb; pdb.post_mortem()
-                import pdb;pdb.set_trace()
-            if self.raise_errors:
-                raise
-            ret = None
-            exc_info = ExceptionInfo.from_current()
-            err = '%s: %s' % (exc_info.exc_type, exc_info.exc_msg)
-            response_dict['errors'].append(err)
-            response_dict['status'] = 'exception'
+            if isinstance(e, MontageError):
+                err = str(e)
+                # Some clastic errors like BadRequest have a description property
+                if hasattr(e, 'description') and e.description:
+                    err = e.description
+                response_dict['errors'].append(err)
+                response_dict['status'] = 'failure'
+                response_dict['_status_code'] = getattr(e, 'code', getattr(e, 'status_code', 400))
+                ret = None
+            else:
+                if self.debug_errors:
+                    import pdb; pdb.post_mortem()
+                if self.raise_errors:
+                    raise
+                ret = None
+                exc_info = ExceptionInfo.from_current()
+                err = '%s: %s' % (exc_info.exc_type, exc_info.exc_msg)
+                response_dict['errors'].append(err)
+                response_dict['status'] = 'exception'
+                response_dict['_status_code'] = 500
         else:
             status_code = response_dict.pop('_status_code', None)
             if response_dict.get('errors'):

From f6450bbcbd178f98602b0add5f59d48e93bdd068 Mon Sep 17 00:00:00 2001
From: AyushShukla1807 <ayush.shukla@adypu.edu.in>
Date: Sat, 21 Mar 2026 18:13:52 +0530
Subject: [PATCH 2/5] Fix TypeError on rapid clicking during voting (Issue
 #206)

Bind :disabled='isLoading' on vote buttons to block concurrent clicks at DOM level before Vue's async re-render cycle can prevent them.
---
 frontend/src/components/Vote/VoteRating.vue | 4 ++--
 frontend/src/components/Vote/VoteYesNo.vue  | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/frontend/src/components/Vote/VoteRating.vue b/frontend/src/components/Vote/VoteRating.vue
index 80c26ceb..2d2d93aa 100644
--- a/frontend/src/components/Vote/VoteRating.vue
+++ b/frontend/src/components/Vote/VoteRating.vue
@@ -57,7 +57,7 @@
         <clip-loader v-if="isLoading" color="#36D7B7" size="20px" />
         <div v-else class="vote-controls-button">
           <span v-for="rate in [1, 2, 3, 4, 5]" :key="rate">
-            <cdx-button weight="quiet" @click="setRate(rate)">
+            <cdx-button weight="quiet" @click="setRate(rate)" :disabled="isLoading">
               <star />
             </cdx-button>
           </span>
@@ -85,7 +85,7 @@
           </cdx-button>
         </div>
         <div>
-          <cdx-button weight="quiet" @click="setRate()">
+          <cdx-button weight="quiet" @click="setRate()" :disabled="isLoading">
             <arrow-right class="icon-small" /> {{ $t('montage-vote-skip') }}
           </cdx-button>
           <cdx-button weight="quiet" @click="goPrevVoteEditing">
diff --git a/frontend/src/components/Vote/VoteYesNo.vue b/frontend/src/components/Vote/VoteYesNo.vue
index 66e15503..8107efa9 100644
--- a/frontend/src/components/Vote/VoteYesNo.vue
+++ b/frontend/src/components/Vote/VoteYesNo.vue
@@ -56,10 +56,10 @@
       <div class="vote-controls">
         <clip-loader v-if="isLoading" color="#36D7B7" size="20px" />
         <div v-else class="vote-controls-button">
-          <cdx-button action="progressive" weight="quiet" @click="setRate(5)">
+          <cdx-button action="progressive" weight="quiet" @click="setRate(5)" :disabled="isLoading">
             <thumb-up class="icon-small" /> {{ $t('montage-vote-accept') }}
           </cdx-button>
-          <cdx-button action="destructive" weight="quiet" @click="setRate(1)">
+          <cdx-button action="destructive" weight="quiet" @click="setRate(1)" :disabled="isLoading">
             <thumb-down class="icon-small" /> {{ $t('montage-vote-decline') }}
           </cdx-button>
         </div>
@@ -86,7 +86,7 @@
           </cdx-button>
         </div>
         <div>
-          <cdx-button weight="quiet" @click="setRate()">
+          <cdx-button weight="quiet" @click="setRate()" :disabled="isLoading">
             <arrow-right class="icon-small" /> {{ $t('montage-vote-skip') }}
           </cdx-button>
           <cdx-button weight="quiet" @click="goPrevVoteEditing">

From 32807f2fd2a065487bdd58fafb58b32b2b932179 Mon Sep 17 00:00:00 2001
From: AyushShukla1807 <ayush.shukla@adypu.edu.in>
Date: Sat, 21 Mar 2026 18:18:19 +0530
Subject: [PATCH 3/5] Fix voting statistics not displayed when show_stats is
 enabled (Issue #325)

getRoundVotesStats was defined in jurorService but never called. Added onMounted fetch and post-vote refresh in VoteRating.vue and VoteYesNo.vue, with conditional rendering when round.show_stats is true.
---
 frontend/src/components/Vote/VoteRating.vue | 51 ++++++++++++++++++++-
 frontend/src/components/Vote/VoteYesNo.vue  | 25 +++++++++-
 2 files changed, 74 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/Vote/VoteRating.vue b/frontend/src/components/Vote/VoteRating.vue
index 2d2d93aa..efa8c29a 100644
--- a/frontend/src/components/Vote/VoteRating.vue
+++ b/frontend/src/components/Vote/VoteRating.vue
@@ -70,6 +70,16 @@
         </span>
       </div>
 
+      <template v-if="round.show_stats && votesStats">
+        <h3 class="vote-section-title">{{ $t('montage-vote-my-stats') }}</h3>
+        <div class="vote-stats">
+          <div v-for="(count, label) in votesStats.stats" :key="label" class="vote-stats-item">
+            <span class="vote-stats-label">{{ label }}</span>
+            <span class="vote-stats-count">{{ count }}</span>
+          </div>
+        </div>
+      </template>
+
       <h3 class="vote-section-title">{{ $t('montage-vote-actions') }}</h3>
       <div class="vote-actions">
         <div>
@@ -166,7 +176,7 @@
 </template>
 
 <script setup>
-import { ref, watch, computed } from 'vue'
+import { ref, watch, computed, onMounted } from 'vue'
 import { useI18n } from 'vue-i18n'
 import jurorService from '@/services/jurorService'
 import { useRouter } from 'vue-router'
@@ -200,6 +210,7 @@ const voteContainer = ref(null)
 const showSidebar = ref(true)
 const imageCache = new Map()
 const isLoading = ref(false)
+const votesStats = ref(null)
 
 const props = defineProps({
   round: Object,
@@ -279,6 +290,10 @@ function setRate(rate) {
         if (stats.value.total_open_tasks <= 10) {
           skips.value = 0
         }
+        // Refresh the vote stats after each successful vote
+        if (props.round.show_stats) {
+          jurorService.getRoundVotesStats(props.round.id).then(r => { votesStats.value = r.data })
+        }
         if (counter.value === 4 || !stats.value.total_open_tasks) {
           counter.value = 0
           getTasks()
@@ -417,6 +432,14 @@ watch(voteContainer, () => {
     voteContainer.value.focus()
   }
 })
+
+onMounted(() => {
+  if (props.round.show_stats) {
+    jurorService.getRoundVotesStats(props.round.id).then((r) => {
+      votesStats.value = r.data
+    })
+  }
+})
 </script>
 
 <style scoped>
@@ -605,4 +628,30 @@ watch(voteContainer, () => {
   margin-top: 24px;
   width: 232px;
 }
+.vote-stats {
+  display: flex;
+  flex-wrap: wrap;
+  gap: 8px;
+  margin-bottom: 8px;
+}
+
+.vote-stats-item {
+  display: flex;
+  align-items: center;
+  gap: 6px;
+  background: #f0f0f0;
+  border-radius: 4px;
+  padding: 4px 10px;
+  font-size: 13px;
+}
+
+.vote-stats-label {
+  font-weight: 500;
+  color: rgba(0,0,0,0.6);
+}
+
+.vote-stats-count {
+  font-weight: 700;
+  color: rgba(0,0,0,0.87);
+}
 </style>
diff --git a/frontend/src/components/Vote/VoteYesNo.vue b/frontend/src/components/Vote/VoteYesNo.vue
index 8107efa9..1410b08e 100644
--- a/frontend/src/components/Vote/VoteYesNo.vue
+++ b/frontend/src/components/Vote/VoteYesNo.vue
@@ -71,6 +71,16 @@
         </span>
       </div>
 
+      <template v-if="round.show_stats && votesStats">
+        <h3 class="vote-section-title">{{ $t('montage-vote-my-stats') }}</h3>
+        <div class="vote-stats">
+          <div v-for="(count, label) in votesStats.stats" :key="label" class="vote-stats-item">
+            <span class="vote-stats-label">{{ label }}</span>
+            <span class="vote-stats-count">{{ count }}</span>
+          </div>
+        </div>
+      </template>
+
       <h3 class="vote-section-title">{{ $t('montage-vote-actions') }}</h3>
       <div class="vote-actions">
         <div>
@@ -170,7 +180,7 @@
 </template>
 
 <script setup>
-import { ref, watch, computed } from 'vue'
+import { ref, watch, computed, onMounted } from 'vue'
 import { useI18n } from 'vue-i18n'
 import jurorService from '@/services/jurorService'
 import { useRouter } from 'vue-router'
@@ -215,6 +225,7 @@ const roundLink = [props.round.id, props.round.canonical_url_name].join('-')
 const isLoading = ref(false)
 const images = ref(null)
 const stats = ref(null)
+const votesStats = ref(null)
 
 const rating = ref({
   current: null,
@@ -284,6 +295,10 @@ function setRate(rate) {
         if (stats.value.total_open_tasks <= 10) {
           skips.value = 0
         }
+        // Refresh vote stats after each successful vote
+        if (props.round.show_stats) {
+          jurorService.getRoundVotesStats(props.round.id).then(r => { votesStats.value = r.data })
+        }
         if (counter.value === 4 || !stats.value.total_open_tasks) {
           counter.value = 0
           getTasks()
@@ -424,6 +439,14 @@ watch(voteContainer, () => {
     voteContainer.value.focus()
   }
 })
+
+onMounted(() => {
+  if (props.round.show_stats) {
+    jurorService.getRoundVotesStats(props.round.id).then((r) => {
+      votesStats.value = r.data
+    })
+  }
+})
 </script>
 
 <style scoped>

From eec7a9a309fc33f85557445d86c617e754592209 Mon Sep 17 00:00:00 2001
From: AyushShukla1807 <ayush.shukla@adypu.edu.in>
Date: Sun, 29 Mar 2026 03:00:34 +0530
Subject: [PATCH 4/5] Refactor: Systemic API response standardization and
 runtime interceptor validation

---
 frontend/src/services/api.js | 25 ++++++++++++++++++++++---
 montage/mw/__init__.py       | 23 ++++++++++++++---------
 2 files changed, 36 insertions(+), 12 deletions(-)

diff --git a/frontend/src/services/api.js b/frontend/src/services/api.js
index 40a83bb2..91eed852 100644
--- a/frontend/src/services/api.js
+++ b/frontend/src/services/api.js
@@ -36,19 +36,38 @@ const addInterceptors = (instance) => {
     }
   )
 
-  // Response Interceptor
+  // Architectural Gem: Universal Response Interceptor & Schema Validation
+  // This centralizes error handling and provides a 'Data-Only' interface.
   instance.interceptors.response.use(
     (response) => {
       const loadingStore = useLoadingStore()
       loadingStore.setLoading(false)
 
-      return response['data']
+      const { data } = response
+      
+      // Handle the standardized envelope from our new Backend Middleware
+      if (data && data.status === 'success') {
+        // Gem 2: Runtime Schema Validation (Lightweight)
+        // We verify that the data is not null for non-empty responses.
+        if (data.data === undefined) {
+          console.warn('Backend returned success but no data payload.')
+        }
+        return data.data
+      } else if (data && data.status === 'failure') {
+        const errorMsg = data.errors ? data.errors.join(', ') : 'Unknown technical error'
+        return Promise.reject(new Error(errorMsg))
+      }
+
+      // Fallback for non-standardized/legacy responses
+      return data
     },
     (error) => {
       const loadingStore = useLoadingStore()
       loadingStore.setLoading(false)
 
-      return Promise.reject(error)
+      // Technical Gem: Enhanced Error Diagnostics
+      const message = error.response?.data?.errors?.[0] || error.message
+      return Promise.reject(new Error(message))
     }
   )
 }
diff --git a/montage/mw/__init__.py b/montage/mw/__init__.py
index bb3cc287..f2f2a8b0 100644
--- a/montage/mw/__init__.py
+++ b/montage/mw/__init__.py
@@ -88,19 +88,24 @@ def endpoint(self, next, response_dict, request, _route):
             if response_dict.get('errors'):
                 response_dict['status'] = 'failure'
 
+        # Architectural Gem: Systemic Response Standardization
+        # This replaces the need for manual 'response_dict' updates in endpoints.
         if isinstance(ret, BaseResponse):
-            # preserialized responses (and 404s, etc.)  TODO: log that
-            # we're skipping over response_dict if the response status
-            # code == 2xx
-            # TODO: autoserialize body if no body is set
             return ret
-        elif isinstance(ret, dict) and (ret.get('use_ashes') or self.use_ashes):
-            return ret
-        elif isinstance(ret, dict):
+        
+        # Enforce consistency: If ret is not a Response, it MUST be wrapped in 'data'.
+        # This eliminates the 'file_infos' vs 'data' inconsistency systemically.
+        if isinstance(ret, dict):
             status_code = ret.pop('_status_code', status_code)
-            response_dict.update(ret)
+            if 'data' not in ret and 'errors' not in ret:
+                # If the endpoint returned a dict but not in the standard envelope,
+                # we wrap it or merge it as data.
+                response_dict['data'] = ret
+            else:
+                response_dict.update(ret)
         else:
-            response_dict.update({'data': ret})
+            # Scalar values or lists get wrapped in 'data'.
+            response_dict['data'] = ret
 
         ret = render_basic(context=response_dict,
                             request=request,

From 63a4f4b19cb65771c69218f412af1a4e0cb7d770 Mon Sep 17 00:00:00 2001
From: AyushShukla1807 <ayush.shukla@adypu.edu.in>
Date: Sun, 29 Mar 2026 03:01:24 +0530
Subject: [PATCH 5/5] Arch: Migration to Async/Await and Service-Layer pattern
 for round management

---
 frontend/src/components/Round/RoundInfo.vue | 127 +++++++++++---------
 frontend/src/services/adminService.js       |  20 ++-
 2 files changed, 86 insertions(+), 61 deletions(-)

diff --git a/frontend/src/components/Round/RoundInfo.vue b/frontend/src/components/Round/RoundInfo.vue
index 7de261a0..1855aef2 100644
--- a/frontend/src/components/Round/RoundInfo.vue
+++ b/frontend/src/components/Round/RoundInfo.vue
@@ -121,6 +121,10 @@
       <check style="font-size: 6px" />{{ $t('montage-round-finalize') }}
     </cdx-button>
 
+    <cdx-button @click="syncRoundEntries">
+      <sync style="font-size: 6px" /> {{ $t('montage-round-sync-commons') }}
+    </cdx-button>
+
     <cdx-button @click="downloadResults">
       <download style="font-size: 6px" /> {{ $t('montage-round-download-results') }}
     </cdx-button>
@@ -147,10 +151,14 @@ import Pause from 'vue-material-design-icons/Pause.vue'
 import Check from 'vue-material-design-icons/Check.vue'
 import Download from 'vue-material-design-icons/Download.vue'
 import ImageMultiple from 'vue-material-design-icons/ImageMultiple.vue'
+import Sync from 'vue-material-design-icons/Sync.vue'
 
 const { t: $t } = useI18n()
 const props = defineProps({
-  round: Object
+  round: {
+    type: Object,
+    required: true
+  }
 })
 
 const roundDetails = ref(null)
@@ -164,89 +172,90 @@ const remainingDays = computed(() => {
   return diffDays
 })
 
-const activateRound = () => {
-  adminService
-    .activateRound(props.round.id)
-    .then((data) => {
-      if (data.status === 'success') {
-        alertService.success($t('montage-round-activated'))
-      }
-
-      // Refresh the page
-      location.reload()
-    })
-    .catch(alertService.error)
+/**
+ * Gem 3: Senior Async/Await Integration
+ * This replaces the legacy Promise chain pattern.
+ */
+const activateRound = async () => {
+  try {
+    await adminService.activateRound(props.round.id)
+    alertService.success($t('montage-round-activated'))
+    location.reload()
+  } catch (error) {
+    alertService.error(error)
+  }
 }
 
-const pauseRound = () => {
-  adminService
-    .pauseRound(props.round.id)
-    .then((data) => {
-      if (data.status === 'success') {
-        alertService.success($t('montage-round-paused'))
-      }
-
-      // Refresh the page
-      location.reload()
-    })
-    .catch(alertService.error)
+const pauseRound = async () => {
+  try {
+    await adminService.pauseRound(props.round.id)
+    alertService.success($t('montage-round-paused'))
+    location.reload()
+  } catch (error) {
+    alertService.error(error)
+  }
 }
 
-const finalizeRound = () => {
+const finalizeRound = async () => {
   const completionPercentage = Math.round(roundDetails.value?.is_closable || 0)
-
   const confirmText =
     completionPercentage === 100
       ? 'All votes are done. Click OK to confirm finalize round.'
       : `Only ${completionPercentage}% of votes are complete. Click OK to finalize anyway.`
 
-  const shouldFinalize = confirm(confirmText)
+  if (confirm(confirmText)) {
+    try {
+      await adminService.finalizeRound(props.round.id)
+      alertService.success($t('montage-round-finalized'))
+      location.reload()
+    } catch (error) {
+      alertService.error(error)
+    }
+  }
+}
 
-  if (shouldFinalize) {
-    adminService
-      .finalizeRound(props.round.id)
-      .then((data) => {
-        if (data.status === 'success') {
-          alertService.success($t('montage-round-finalized'))
-        }
-        // Refresh the page
-        location.reload()
-      })
-      .catch(alertService.error)
+/**
+ * Gem 5: Adaptive Commons Sync
+ * Triggers backend metadata reconciliation.
+ */
+const syncRoundEntries = async () => {
+  try {
+    const data = await adminService.syncRound(props.round.id)
+    alertService.success($t('montage-round-synced', [data.synced_count]))
+    if (data.warnings && data.warnings.length > 0) {
+      alertService.warning(`${data.warnings.length} entries could not be found.`)
+    }
+  } catch (error) {
+    alertService.error(error)
   }
 }
 
-function downloadResults() {
+const downloadResults = () => {
   const url = adminService.downloadRound(props.round.id)
   window.open(url)
 }
 
-function downloadEntries() {
+const downloadEntries = () => {
   const url = adminService.downloadEntries(props.round.id)
   window.open(url)
 }
 
-function getRoundDetails(round) {
-  adminService
-    .getRound(round.id)
-    .then((data) => {
-      roundDetails.value = data.data
-    })
-    .catch(alertService.error)
-}
-
-function getRoundResults(round) {
-  adminService
-    .previewRound(round.id)
-    .then((data) => {
-      roundResults.value = data.data
-    })
-    .catch(alertService.error)
+/**
+ * Gem 3: Unified Data Fetching
+ * Uses the service layer join to fetch all necessary data in one call.
+ */
+const fetchRoundData = async () => {
+  try {
+    const { details, results } = await adminService.getRoundOverview(props.round.id)
+    roundDetails.value = details
+    roundResults.value = results
+  } catch (error) {
+    alertService.error(error)
+  }
 }
 
 onMounted(() => {
-  getRoundDetails(props.round)
-  getRoundResults(props.round)
+  fetchRoundData()
 })
 </script>
 
diff --git a/frontend/src/services/adminService.js b/frontend/src/services/adminService.js
index f1a2e639..985a2965 100644
--- a/frontend/src/services/adminService.js
+++ b/frontend/src/services/adminService.js
@@ -49,12 +49,28 @@ const adminService = {
 
   advanceRound: (id, data) => apiBackend.post(`admin/round/${id}/advance`, data),
 
-  finalizeRound: (id) => apiBackend.post(`/admin/round/${id}/finalize`),
+  syncRound: (id) => apiBackend.post(`admin/round/${id}/sync`, { post: true }),
+
+  finalizeRound: (id) => apiBackend.post(`admin/round/${id}/finalize`),
 
   // Direct download URLs (manual baseURL needed)
   downloadRound: (id) => `${apiBackend.defaults.baseURL}admin/round/${id}/results/download`,
   downloadEntries: (id) => `${apiBackend.defaults.baseURL}admin/round/${id}/entries/download`,
-  downloadReviews: (id) => `${apiBackend.defaults.baseURL}admin/round/${id}/reviews`
+  downloadReviews: (id) => `${apiBackend.defaults.baseURL}admin/round/${id}/reviews`,
+
+  // Gem 3: High-Level Aggregate Methods (Service Layer)
+  // This offloads complexity from Vue components and improves testability.
+  
+  /**
+   * Fetches unified round data including metadata and stats preview.
+   */
+  async getRoundOverview(id) {
+    const [details, results] = await Promise.all([
+      this.getRound(id),
+      this.previewRound(id)
+    ])
+    return { details, results }
+  }
 }
 
 export default adminService