Implement v2-gen-bounds function#10840
Merged
Merged
Conversation
81e2cb7 to
04c7f02
Compare
fgaz
reviewed
Mar 20, 2025
b7dac1b to
6ae908d
Compare
Member
|
Is it ready for review? |
Member
|
I think it is, I just didn't re-review it yet:) |
Member
|
@fgaz: just a reminder, once it's ready, pretty-please add the review-needed label. |
Collaborator
Author
|
Hi, two months without any more reviews on this patch. Please can I merge it? |
geekosaur
approved these changes
May 21, 2025
geekosaur
left a comment
Collaborator
There was a problem hiding this comment.
I'm approving this for now, other reviewers might have other opinions about how important avoiding duplication is.
Member
|
Let me prod mergify. |
Member
|
@mergify rebase |
Contributor
✅ Branch has been successfully rebased |
6ae908d to
4e0ad33
Compare
This commit implements project-aware functionality for the `cabal gen-bounds` command, allowing it to work correctly in multi-package projects. Previously, running `gen-bounds` from within a package directory that depends on another local package would fail because it couldn't find the local dependency. The implementation follows the same pattern as other v2 commands, creating a full project context that knows about all packages defined in the cabal.project file. This allows `gen-bounds` to properly analyze dependencies between local packages and suggest appropriate bounds. ``` cabal gen-bounds <TARGET> ``` Fixes #7504 #8654 #9752 #5932
4e0ad33 to
b41f09a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements project-aware functionality for the
cabal gen-boundscommand, allowing it to work correctly in multi-package projects. Previously, runninggen-boundsfrom within a package directory that depends on another local package would fail because it couldn't find the local dependency.The implementation follows the same pattern as other v2 commands, creating a full project context that knows about all packages defined in the cabal.project file. This allows
gen-boundsto properly analyze dependencies between local packages and suggest appropriate bounds.Fixes #7504
Fixes #8654
Fixes #9752
Fixes #5932
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: