minor #131 Remove some deprecations (phansys)

This PR was merged into the master branch.

Discussion
----------

|Q            |A     |
|---          |---   |
|Branch       |master|
|Bug fix?     |no    |
|New feature? |no    |
|BC breaks?   |no    |
|Deprecations?|no    |
|Tests pass?  |yes   |
|Fixed tickets|n/a   |
|License      |MIT   |
|Doc PR       |n/a   |

Commits
-------

40545ad Fixed some deprecations

Author: phansys

Command/AutoClosingCommand.php

@@ -11,13 +11,15 @@
 
 class AutoClosingCommand extends ContainerAwareCommand
 {
+    protected static $defaultName = 'ticket:autoclosing';
+
     /**
      * {@inheritdoc}
      */
     protected function configure()
     {
         $this
-            ->setName('ticket:autoclosing')
+            ->setName(static::$defaultName) // BC for symfony/console < 3.4.0
             ->setDescription('Automatically close resolved tickets still opened')
             ->addArgument(
                 'username',

Command/TicketManagerCommand.php

@@ -11,13 +11,15 @@
 
 class TicketManagerCommand extends ContainerAwareCommand
 {
+    protected static $defaultName = 'ticket:create';
+
     /**
      * {@inheritdoc}
      */
     protected function configure()
     {
         $this
-            ->setName('ticket:create')
+            ->setName(static::$defaultName) // BC for symfony/console < 3.4.0
             ->setDescription('Create a new Ticket')
             ->addArgument(
                 'subject',

DependencyInjection/Configuration.php

@@ -17,9 +17,15 @@ class Configuration implements ConfigurationInterface
      */
     public function getConfigTreeBuilder()
     {
-        $treeBuilder = new TreeBuilder();
+        $treeBuilder = new TreeBuilder('hackzilla_ticket');
+        if (method_exists($treeBuilder, 'getRootNode')) {
+            $rootNode = $treeBuilder->getRootNode();
+        } else {
+            // BC layer for symfony/config 4.1 and older
+            $rootNode = $treeBuilder->root('hackzilla_ticket');
+        }
 
-        $treeBuilder->root('hackzilla_ticket')
+        $rootNode
             ->children()
                 ->scalarNode('user_class')->isRequired()->cannotBeEmpty()->end()
                 ->scalarNode('ticket_class')->cannotBeEmpty()->defaultValue('Hackzilla\Bundle\TicketBundle\Entity\Ticket')->end()

Resources/config/services.yml

@@ -70,3 +70,13 @@ services:
         class: Hackzilla\Bundle\TicketBundle\EventListener\FileSubscriber
         tags:
             - { name: kernel.event_subscriber }
+
+    hackzilla_ticket.command.autoclosing:
+        class: Hackzilla\Bundle\TicketBundle\Command\AutoClosingCommand
+        tags:
+            - { name: console.command, command: ticket:autoclosing }
+
+    hackzilla_ticket.command.create:
+        class: Hackzilla\Bundle\TicketBundle\Command\TicketManagerCommand
+        tags:
+            - { name: console.command, command: ticket:create }