Skip to content

Conversation

@mkruskal-google
Copy link
Contributor

@mkruskal-google mkruskal-google commented Oct 30, 2025

Fixes: #8642

grpc-go isn't doing anything that should be affected by edition 2024, so it should already support it. This simply advertises it so protoc will send it edition 2024 protos without requiring an --experimental_editions flag.

relnotes for cmd/protoc-gen-go-grpc:

  • Add support for protobuf edition 2024.

RELEASE NOTES: N/A

@mkruskal-google mkruskal-google changed the title Update supported edition to 2024 feat: update supported edition to 2024 Oct 30, 2025
@mkruskal-google mkruskal-google changed the title feat: update supported edition to 2024 Update supported edition to 2024 Oct 30, 2025
@arjan-bal arjan-bal added Type: Feature New features or improvements in behavior Area: Codegen Includes anything related to protoc-gen-go-grpc. labels Oct 30, 2025
@arjan-bal arjan-bal added this to the 1.78 Release milestone Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.28%. Comparing base (dfbfdf8) to head (bcf23fb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8685      +/-   ##
==========================================
+ Coverage   83.23%   83.28%   +0.04%     
==========================================
  Files         415      415              
  Lines       32134    32134              
==========================================
+ Hits        26748    26762      +14     
+ Misses       4012     4005       -7     
+ Partials     1374     1367       -7     

see 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal changed the title Update supported edition to 2024 protoc-gen-go-grpc: Update supported edition to 2024 Oct 30, 2025
Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjan-bal arjan-bal merged commit 64cba2d into grpc:master Oct 30, 2025
16 of 22 checks passed
@mkruskal-google mkruskal-google deleted the patch-1 branch October 30, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Codegen Includes anything related to protoc-gen-go-grpc. Type: Feature New features or improvements in behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[protoc-gen-go-grpc] Support Protobuf edition 2024

2 participants