This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Fix unhandled rejection #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making sure we're passing the right target to newly launched chrome instance and later into the CDP.Close(...) call Closes schickling#187
adieuadieu
approved these changes
Aug 12, 2017
Collaborator
adieuadieu
left a comment
There was a problem hiding this comment.
Hi @janza Thank you for debugging this issue and fixing it!
schickling
approved these changes
Aug 12, 2017
Collaborator
|
Thank you @janza! |
|
Nice 👍 Does somebody know when it will released? |
webpolis
pushed a commit
to webpolis/yb-chromeless
that referenced
this pull request
Oct 5, 2017
Fix unhandled rejection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making sure we're passing the right target to newly launched chrome
instance and later into the CDP.Close(...) call
Closes #187