rewrite cookie endpoints: deleteCookies & clearCookies and fix clearCookies #123
Conversation
… show any feedback if cookies could not be cleared
|
Just a note: changing the API method names would be considered a breaking change meaning a bump in the major version. It's probably OK to rename for now without a major bump, but this would be the exception. @joelgriffith @timsuchanek? Furthermore, I'm wondering about naming convention. If we've adopted the |
| cookiesDelete(name: string, url: string): Chromeless<T> { | ||
| if (typeof name === 'undefined') { | ||
| throw new Error('Cookie name should be defined.') | ||
| } |
There was a problem hiding this comment.
We could probably have this method lookup the URL since it'll likely be ran in the context of the page it's in. This is good for now, but might be a nice change/improvement later on!
|
@adieuadieu so you mean |
|
@joeyvandijk let's rename the others in another PR. Technically we're introducing breaking changes... |
… update documentation
adieuadieu
left a comment
There was a problem hiding this comment.
Thank you, @joeyvandijk!
|
👍 |
cookiesCleardid not check if it could be executed, so added that check, but also rewrote the API names to make it more clear what both endpoints do(n't).