style: remove unnecessary log formatting calls

njhale · njhale · commit d4981fac8fbc · 2024-02-23T23:44:47.000-05:00
Signed-off-by: Nick Hale &lt;4175918+njhale@users.noreply.github.com&gt;
diff --git a/pkg/builtin/builtin.go b/pkg/builtin/builtin.go
@@ -270,8 +270,7 @@ func SysWrite(ctx context.Context, env []string, input string) (string, error) {
 	defer locker.Unlock(params.Filename)
 
 	data := []byte(params.Content)
-	msg := fmt.Sprintf("Wrote %d bytes to file %s", len(data), params.Filename)
-	log.Debugf(msg)
+	log.Debugf("Wrote %d bytes to file %s", len(data), params.Filename)
 
 	return "", os.WriteFile(params.Filename, data, 0644)
 }
@@ -301,10 +300,9 @@ func SysAppend(ctx context.Context, env []string, input string) (string, error)
 		return "", err
 	}
 
-	msg := fmt.Sprintf("Appended %d bytes to file %s", n, params.Filename)
-	log.Debugf(msg)
+	log.Debugf("Appended %d bytes to file %s", n, params.Filename)
 
-	return "", err
+	return "", nil
 }
 
 func fixQueries(u string) (string, error) {

Original file line number	Diff line number	Diff line change
`@@ -270,8 +270,7 @@ func SysWrite(ctx context.Context, env []string, input string) (string, error) {`
`270`	`270`	`defer locker.Unlock(params.Filename)`
`271`	`271`
`272`	`272`	`data := []byte(params.Content)`
`273`		`- msg := fmt.Sprintf("Wrote %d bytes to file %s", len(data), params.Filename)`
`274`		`- log.Debugf(msg)`
	`273`	`+ log.Debugf("Wrote %d bytes to file %s", len(data), params.Filename)`
`275`	`274`
`276`	`275`	`return "", os.WriteFile(params.Filename, data, 0644)`
`277`	`276`	`}`
`@@ -301,10 +300,9 @@ func SysAppend(ctx context.Context, env []string, input string) (string, error)`
`301`	`300`	`return "", err`
`302`	`301`	`}`
`303`	`302`
`304`		`- msg := fmt.Sprintf("Appended %d bytes to file %s", n, params.Filename)`
`305`		`- log.Debugf(msg)`
	`303`	`+ log.Debugf("Appended %d bytes to file %s", n, params.Filename)`
`306`	`304`
`307`		`- return "", err`
	`305`	`+ return "", nil`
`308`	`306`	`}`
`309`	`307`
`310`	`308`	`func fixQueries(u string) (string, error) {`