Skip to content

refactor(storage): deprecate preserve_acl arg in copy_blob() method #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankyn merged 6 commits into from
Apr 20, 2020
Merged

refactor(storage): deprecate preserve_acl arg in copy_blob() method #104

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
edd0137
refactor(storage): deprecate preserve_acl arg in copy_blob() method
Apr 13, 2020
a46a3a0
Merge branch 'master' into preserve_acl_deprecation
frankyn Apr 17, 2020
0887838
Revert "refactor(storage): deprecate preserve_acl arg in copy_blob() …
Apr 17, 2020
d43b68e
add deprecation warning into docs, provide a snippet of how to copy ACL
Apr 17, 2020
227d3fd
Merge branch 'preserve_acl_deprecation' of https://github.com/q-logic…
Apr 17, 2020
1ca6152
Merge branch 'master' into preserve_acl_deprecation
frankyn Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion google/cloud/storage/bucket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,8 @@ def copy_blob(
to the ``client`` stored on the current bucket.

:type preserve_acl: bool
:param preserve_acl: (Optional) Copies ACL from old blob to new blob.
:param preserve_acl: DEPRECATED. This argument is not functional!
(Optional) Copies ACL from old blob to new blob.
Default: True.

:type source_generation: long
Expand All @@ -1288,6 +1289,20 @@ def copy_blob(

:rtype: :class:`google.cloud.storage.blob.Blob`
:returns: The new Blob.

Example:
Copy a blob including ACL.

>>> from google.cloud import storage

>>> client = storage.Client(project="project")

>>> bucket = client.bucket("bucket")
>>> dst_bucket = client.bucket("destination-bucket")

>>> blob = bucket.blob("file.ext")
>>> new_blob = bucket.copy_blob(blob, dst_bucket)
>>> new_blob.acl.save(blob.acl)
"""
client = self._require_client(client)
query_params = {}
Expand Down