Skip to content

fix: bump default deadline on CreateDatabase and RestoreDatabase to 2 minutes #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-sanche merged 11 commits into from
Jan 21, 2025
Merged

fix: bump default deadline on CreateDatabase and RestoreDatabase to 2 minutes #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0d4ed1a
chore: Update gapic-generator-python to v1.19.1
gcf-owl-bot[bot] Oct 11, 2024
b7c4e67
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 11, 2024
e6fda23
chore: Configure Ruby clients for google-ads-ad_manager
gcf-owl-bot[bot] Oct 24, 2024
7efe477
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 24, 2024
0fc723e
chore: remove body selector from http rule
gcf-owl-bot[bot] Nov 5, 2024
7dc2090
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Nov 5, 2024
49c3d59
feat: Add support for opt-in debug logging
gcf-owl-bot[bot] Dec 12, 2024
be07bee
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 12, 2024
80865a5
fix: bump default deadline on CreateDatabase and RestoreDatabase to 2…
gcf-owl-bot[bot] Jan 17, 2025
06b4e7b
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 17, 2025
9b81248
Merge branch 'main' into owl-bot-copy
daniel-sanche Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
280 changes: 176 additions & 104 deletions google/cloud/firestore_admin_v1/services/firestore_admin/async_client.py
View file
Open in desktop

Large diffs are not rendered by default.

325 changes: 184 additions & 141 deletions google/cloud/firestore_admin_v1/services/firestore_admin/client.py
View file
Open in desktop

Large diffs are not rendered by default.

32 changes: 20 additions & 12 deletions google/cloud/firestore_admin_v1/services/firestore_admin/pagers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def __init__(
*,
retry: OptionalRetry = gapic_v1.method.DEFAULT,
timeout: Union[float, object] = gapic_v1.method.DEFAULT,
metadata: Sequence[Tuple[str, str]] = ()
metadata: Sequence[Tuple[str, Union[str, bytes]]] = ()
):
"""Instantiate the pager.

Expand All @@ -82,8 +82,10 @@ def __init__(
retry (google.api_core.retry.Retry): Designation of what errors,
if any, should be retried.
timeout (float): The timeout for this request.
metadata (Sequence[Tuple[str, str]]): Strings which should be
sent along with the request as metadata.
metadata (Sequence[Tuple[str, Union[str, bytes]]]): Key/value pairs which should be
sent along with the request as metadata. Normally, each value must be of type `str`,
but for metadata keys ending with the suffix `-bin`, the corresponding values must
be of type `bytes`.
"""
self._method = method
self._request = firestore_admin.ListIndexesRequest(request)
Expand Down Expand Up @@ -142,7 +144,7 @@ def __init__(
*,
retry: OptionalAsyncRetry = gapic_v1.method.DEFAULT,
timeout: Union[float, object] = gapic_v1.method.DEFAULT,
metadata: Sequence[Tuple[str, str]] = ()
metadata: Sequence[Tuple[str, Union[str, bytes]]] = ()
):
"""Instantiates the pager.

Expand All @@ -156,8 +158,10 @@ def __init__(
retry (google.api_core.retry.AsyncRetry): Designation of what errors,
if any, should be retried.
timeout (float): The timeout for this request.
metadata (Sequence[Tuple[str, str]]): Strings which should be
sent along with the request as metadata.
metadata (Sequence[Tuple[str, Union[str, bytes]]]): Key/value pairs which should be
sent along with the request as metadata. Normally, each value must be of type `str`,
but for metadata keys ending with the suffix `-bin`, the corresponding values must
be of type `bytes`.
"""
self._method = method
self._request = firestore_admin.ListIndexesRequest(request)
Expand Down Expand Up @@ -220,7 +224,7 @@ def __init__(
*,
retry: OptionalRetry = gapic_v1.method.DEFAULT,
timeout: Union[float, object] = gapic_v1.method.DEFAULT,
metadata: Sequence[Tuple[str, str]] = ()
metadata: Sequence[Tuple[str, Union[str, bytes]]] = ()
):
"""Instantiate the pager.

Expand All @@ -234,8 +238,10 @@ def __init__(
retry (google.api_core.retry.Retry): Designation of what errors,
if any, should be retried.
timeout (float): The timeout for this request.
metadata (Sequence[Tuple[str, str]]): Strings which should be
sent along with the request as metadata.
metadata (Sequence[Tuple[str, Union[str, bytes]]]): Key/value pairs which should be
sent along with the request as metadata. Normally, each value must be of type `str`,
but for metadata keys ending with the suffix `-bin`, the corresponding values must
be of type `bytes`.
"""
self._method = method
self._request = firestore_admin.ListFieldsRequest(request)
Expand Down Expand Up @@ -294,7 +300,7 @@ def __init__(
*,
retry: OptionalAsyncRetry = gapic_v1.method.DEFAULT,
timeout: Union[float, object] = gapic_v1.method.DEFAULT,
metadata: Sequence[Tuple[str, str]] = ()
metadata: Sequence[Tuple[str, Union[str, bytes]]] = ()
):
"""Instantiates the pager.

Expand All @@ -308,8 +314,10 @@ def __init__(
retry (google.api_core.retry.AsyncRetry): Designation of what errors,
if any, should be retried.
timeout (float): The timeout for this request.
metadata (Sequence[Tuple[str, str]]): Strings which should be
sent along with the request as metadata.
metadata (Sequence[Tuple[str, Union[str, bytes]]]): Key/value pairs which should be
sent along with the request as metadata. Normally, each value must be of type `str`,
but for metadata keys ending with the suffix `-bin`, the corresponding values must
be of type `bytes`.
"""
self._method = method
self._request = firestore_admin.ListFieldsRequest(request)
Expand Down
9 changes: 9 additions & 0 deletions google/cloud/firestore_admin_v1/services/firestore_admin/transports/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@

transport inheritance structure
_______________________________

`FirestoreAdminTransport` is the ABC for all transports.
- public child `FirestoreAdminGrpcTransport` for sync gRPC transport (defined in `grpc.py`).
- public child `FirestoreAdminGrpcAsyncIOTransport` for async gRPC transport (defined in `grpc_asyncio.py`).
- private child `_BaseFirestoreAdminRestTransport` for base REST transport with inner classes `_BaseMETHOD` (defined in `rest_base.py`).
- public child `FirestoreAdminRestTransport` for sync REST transport with inner classes `METHOD` derived from the parent's corresponding `_BaseMETHOD` classes (defined in `rest.py`).
24 changes: 22 additions & 2 deletions google/cloud/firestore_admin_v1/services/firestore_admin/transports/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ def _prep_wrapped_messages(self, client_info):
),
self.create_database: gapic_v1.method.wrap_method(
self.create_database,
default_timeout=None,
default_timeout=120.0,
client_info=client_info,
),
self.get_database: gapic_v1.method.wrap_method(
Expand Down Expand Up @@ -288,7 +288,7 @@ def _prep_wrapped_messages(self, client_info):
),
self.restore_database: gapic_v1.method.wrap_method(
self.restore_database,
default_timeout=None,
default_timeout=120.0,
client_info=client_info,
),
self.create_backup_schedule: gapic_v1.method.wrap_method(
Expand Down Expand Up @@ -316,6 +316,26 @@ def _prep_wrapped_messages(self, client_info):
default_timeout=None,
client_info=client_info,
),
self.cancel_operation: gapic_v1.method.wrap_method(
self.cancel_operation,
default_timeout=None,
client_info=client_info,
),
self.delete_operation: gapic_v1.method.wrap_method(
self.delete_operation,
default_timeout=None,
client_info=client_info,
),
self.get_operation: gapic_v1.method.wrap_method(
self.get_operation,
default_timeout=None,
client_info=client_info,
),
self.list_operations: gapic_v1.method.wrap_method(
self.list_operations,
default_timeout=None,
client_info=client_info,
),
}

def close(self):
Expand Down
Loading
Loading