Skip to content

Commit d37aec5

Browse files
authored
fix: unit test generation for boolean query prams (#1447)
Without this fix the current compute engine tests are failing. Also 3 other APIs in googleapis would have failed if grpc+rest transport was enabled on them.
1 parent b4675f8 commit d37aec5

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

packages/gapic-generator/gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1213,6 +1213,8 @@ def test_{{ method_name }}_rest_required_fields(request_type={{ method.input.ide
12131213
"{{ req_field.name | camel_case }}",
12141214
{% if req_field.field_pb.type == 9 %}
12151215
"{{ req_field.field_pb.default_value }}",
1216+
{% elif req_field.field_pb.type == 8 %}
1217+
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}).lower(),
12161218
{% else %}
12171219
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}),
12181220
{% endif %}{# default is str #}

packages/gapic-generator/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1102,6 +1102,8 @@ def test_{{ method_name }}_rest_required_fields(request_type={{ method.input.ide
11021102
"{{ req_field.name | camel_case }}",
11031103
{% if req_field.field_pb.type == 9 %}
11041104
"{{ req_field.field_pb.default_value }}",
1105+
{% elif req_field.field_pb.type == 8 %}
1106+
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}).lower(),
11051107
{% else %}
11061108
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}),
11071109
{% endif %}{# default is str #}

0 commit comments

Comments
 (0)