chore: replace var with const or let (#36)

Author: DominicKramer

handwritten/nodejs-error-reporting/src/build-stack-trace.ts

@@ -26,11 +26,11 @@ const SRC_ROOT = __dirname;
  *   where this method was invoked.
  */
 export function buildStackTrace(message: string) {
-  var target = {};
+  const target = {};
   // Build a stack trace without the frames associated with `buildStackTrace`.
   // The stack is located at `target.stack`.
   Error.captureStackTrace(target, buildStackTrace);
-  var prefix = message ? message + '\n' : '';
+  const prefix = message ? message + '\n' : '';
   return (
     prefix +
     (target as any).stack

handwritten/nodejs-error-reporting/src/classes/error-message.ts

@@ -15,9 +15,9 @@
  */
 
 import * as is from 'is';
-var isString = is.string;
-var isNumber = is.number;
-var isObject = is.object;
+const isString = is.string;
+const isNumber = is.number;
+const isObject = is.object;
 
 import {RequestInformationContainer} from './request-information-container';
 import {ServiceContext} from '../configuration';

handwritten/nodejs-error-reporting/src/classes/request-information-container.ts

@@ -15,8 +15,8 @@
  */
 
 import * as is from 'is';
-var isString = is.string;
-var isNumber = is.number;
+const isString = is.string;
+const isNumber = is.number;
 
 export class RequestInformationContainer {
   url: string;

handwritten/nodejs-error-reporting/src/configuration.ts

@@ -14,13 +14,13 @@
  * limitations under the License.
  */
 
-var env = process.env;
+const env = process.env;
 import has = require('lodash.has');
 import * as is from 'is';
-var isObject = is.object;
-var isBoolean = is.boolean;
-var isString = is.string;
-var isNumber = is.number;
+const isObject = is.object;
+const isBoolean = is.boolean;
+const isString = is.string;
+const isNumber = is.number;
 
 import {Logger} from '@google-cloud/common';
 
@@ -220,8 +220,8 @@ export class Configuration {
     //   Otherwise, the value of the environment variable GAE_MODULE_VERSION
     //   will be used if and only if the FUNCTION_NAME environment variable is
     //   not set.
-    var service;
-    var version;
+    let service;
+    let version;
 
     if (env.FUNCTION_NAME) {
       service = env.FUNCTION_NAME;

handwritten/nodejs-error-reporting/src/google-apis/auth-client.ts

@@ -19,18 +19,18 @@ import * as common from '@google-cloud/common';
 const pkg = require('../../../package.json');
 import * as is from 'is';
 // TODO: Address the error where `is` does not have a `fn` property
-var isFunction = (is as {} as {fn: Function}).fn;
-var isString = is.string;
+const isFunction = (is as {} as {fn: Function}).fn;
+const isString = is.string;
 
 import {Configuration} from '../configuration';
 import {ErrorMessage} from '../classes/error-message';
 import * as http from 'http';
 
 /* @const {Array<String>} list of scopes needed to work with the errors api. */
-var SCOPES = ['https://www.googleapis.com/auth/cloud-platform'];
+const SCOPES = ['https://www.googleapis.com/auth/cloud-platform'];
 
 /* @const {String} Base Error Reporting API */
-var API = 'https://clouderrorreporting.googleapis.com/v1beta1';
+const API = 'https://clouderrorreporting.googleapis.com/v1beta1';
 
 /**
  * The RequestHandler constructor initializes several properties on the
@@ -96,9 +96,9 @@ export class RequestHandler extends common.Service {
    * @param {Logger} logger - an instance of logger
    */
   constructor(config: Configuration, logger: common.Logger) {
-    var pid = config.getProjectId();
+    const pid = config.getProjectId();
     // If an API key is provided, do not try to authenticate.
-    var tryAuthenticate = !config.getKey();
+    const tryAuthenticate = !config.getKey();
     super(
       {
         packageJson: pkg,
@@ -114,7 +114,7 @@ export class RequestHandler extends common.Service {
     this._config = config;
     this._logger = logger;
 
-    var that = this;
+    const that = this;
     if (tryAuthenticate) {
       this.authClient.getToken(function(err: Error) {
         if (err) {
@@ -167,7 +167,7 @@ export class RequestHandler extends common.Service {
    * @instance
    */
   sendError(errorMessage: ErrorMessage, userCb?: (err: Error|null, response: http.ServerResponse|null, body: any) => void) {
-    var cb: Function = (isFunction(userCb) ? userCb : RequestHandler.noOp)!;
+    const cb: Function = (isFunction(userCb) ? userCb : RequestHandler.noOp)!;
     if (this._config.getShouldReportErrorsToAPI()) {
       this.request(
         {

handwritten/nodejs-error-reporting/src/index.ts

@@ -117,7 +117,7 @@ export class Errors {
     this._client = new AuthClient(this._config, this._logger);
 
     if (this._config.getReportUnhandledRejections()) {
-      var that = this;
+      const that = this;
       process.on('unhandledRejection', function(reason) {
         that._logger.warn(
           'UnhandledPromiseRejectionWarning: ' +
@@ -144,7 +144,7 @@ export class Errors {
      * @example
      * // Use to create and report errors manually with a high-degree
      * // of manual control
-     * var err = errors.event()
+     * const err = errors.event()
      *  .setMessage('My error message')
      *  .setUser('root@nexus');
      * errors.report(err, function () {
@@ -155,8 +155,8 @@ export class Errors {
 
     /**
      * @example
-     * var hapi = require('hapi');
-     * var server = new hapi.Server();
+     * const hapi = require('hapi');
+     * const server = new hapi.Server();
      * server.connection({ port: 3000 });
      * server.start();
      * // AFTER ALL OTHER ROUTE HANDLERS
@@ -166,8 +166,8 @@ export class Errors {
 
     /**
      * @example
-     * var express = require('express');
-     * var app = express();
+     * const express = require('express');
+     * const app = express();
      * // AFTER ALL OTHER ROUTE HANDLERS
      * app.use(errors.express);
      * app.listen(3000);
@@ -176,17 +176,17 @@ export class Errors {
 
     /**
      * @example
-     * var restify = require('restify');
-     * var server = restify.createServer();
+     * const restify = require('restify');
+     * const server = restify.createServer();
      * // BEFORE ALL OTHER ROUTE HANDLERS
      * server.use(errors.restify(server));
      */
     this.restify = restify(this._client, this._config);
 
     /**
      * @example
-     * var koa = require('koa');
-     * var app = koa();
+     * const koa = require('koa');
+     * const app = koa();
      * // BEFORE ALL OTHER ROUTE HANDLERS HANDLERS
      * app.use(errors.koa);
      */

handwritten/nodejs-error-reporting/src/interfaces/express.ts

@@ -15,9 +15,9 @@
  */
 
 import * as is from 'is';
-var isObject = is.object;
+const isObject = is.object;
 // TODO: Address the error where `is` does not have a `fn` property
-var isFunction = (is as {} as {fn: Function}).fn;
+const isFunction = (is as {} as {fn: Function}).fn;
 import {ErrorMessage} from '../classes/error-message';
 import {expressRequestInformationExtractor} from '../request-extractors/express';
 import {populateErrorMessage} from '../populate-error-message';
@@ -48,15 +48,15 @@ export function makeExpressHandler(client: RequestHandler, config: Configuration
    * @returns {ErrorMessage} - Returns the ErrorMessage instance
    */
   function expressErrorHandler(err: {}, req: express.Request, res: express.Response, next: Function) {
-    var ctxService = '';
-    var ctxVersion: string|undefined = '';
+    let ctxService = '';
+    let ctxVersion: string|undefined = '';
 
     if (isObject(config)) {
       ctxService = config.getServiceContext().service;
       ctxVersion = config.getServiceContext().version;
     }
 
-    var em = new ErrorMessage()
+    const em = new ErrorMessage()
       .consumeRequestInformation(expressRequestInformationExtractor(req, res))
       .setServiceContext(ctxService, ctxVersion);
 

handwritten/nodejs-error-reporting/src/interfaces/hapi.ts

@@ -15,13 +15,13 @@
  */
 
 import * as is from 'is';
-var isObject = is.object;
+const isObject = is.object;
 // TODO: Address the error where `is` does not have a `fn` property
-var isFunction = (is as {} as {fn: Function}).fn;
+const isFunction = (is as {} as {fn: Function}).fn;
 import {ErrorMessage} from '../classes/error-message';
 import {hapiRequestInformationExtractor} from '../request-extractors/hapi';
 import {populateErrorMessage} from '../populate-error-message';
-var packageJson = require('../../../package.json');
+const packageJson = require('../../../package.json');
 
 import {RequestHandler} from '../google-apis/auth-client';
 import {Configuration} from '../configuration';
@@ -38,15 +38,15 @@ import * as hapi from 'hapi';
  *  ErrorMessage
  */
 function hapiErrorHandler(req: hapi.Request, err: {}, config: Configuration) {
-  var service = '';
-  var version: string|undefined = '';
+  let service = '';
+  let version: string|undefined = '';
 
   if (isObject(config)) {
     service = config.getServiceContext().service;
     version = config.getServiceContext().version;
   }
 
-  var em = new ErrorMessage()
+  const em = new ErrorMessage()
     .consumeRequestInformation(hapiRequestInformationExtractor(req))
     .setServiceContext(service, version);
 
@@ -93,7 +93,7 @@ export function makeHapiPlugin(client: RequestHandler, config: Configuration) {
             // TODO: Handle the case when `request.response` is null
             request.response!.isBoom
           ) {
-            var em = hapiErrorHandler(
+            const em = hapiErrorHandler(
               request,
               // TODO: Handle the case when `request.response` is null
               // TODO: Handle the type conflict that requires a cast to string
@@ -115,7 +115,7 @@ export function makeHapiPlugin(client: RequestHandler, config: Configuration) {
     }
   }
 
-  var hapiPlugin = {register: hapiRegisterFunction};
+  const hapiPlugin = {register: hapiRegisterFunction};
 
   (hapiPlugin.register as any).attributes = {
     name: packageJson.name,

handwritten/nodejs-error-reporting/src/interfaces/koa.ts

@@ -42,12 +42,12 @@ export function koaErrorHandler(client: RequestHandler, config: Configuration) {
    * @returns {Undefined} does not return anything
    */
   return function*(this: {request: Request; response: Response;}, next: Function) {
-    var svc = config.getServiceContext();
+    const svc = config.getServiceContext();
 
     try {
       yield next;
     } catch (err) {
-      var em = new ErrorMessage()
+      const em = new ErrorMessage()
         .consumeRequestInformation(
           koaRequestInformationExtractor(this.request, this.response)
         )

handwritten/nodejs-error-reporting/src/interfaces/manual.ts

@@ -15,10 +15,10 @@
  */
 
 import * as is from 'is';
-var isString = is.string;
-var isObject = is.object;
+const isString = is.string;
+const isObject = is.object;
 // TODO: Address the error where `is` does not have a `fn` property
-var isFunction = (is as {} as {fn: Function}).fn;
+const isFunction = (is as {} as {fn: Function}).fn;
 import {ErrorMessage} from '../classes/error-message';
 import {manualRequestInformationExtractor} from '../request-extractors/manual';
 import {populateErrorMessage} from '../populate-error-message';
@@ -63,7 +63,7 @@ export function handlerSetup(client: RequestHandler, config: Configuration, logg
    * the parameters given.
    */
   function reportManualError(err: {}, request?: Request, additionalMessage?: string|{}, callback?: Callback|{}|string) {
-    var em;
+    let em;
     if (isString(request)) {
       // no request given
       callback = additionalMessage;