From 35e231c979dcfa028d9e6342d5261543a590b18f Mon Sep 17 00:00:00 2001
From: Jeff Ching <chingor@google.com>
Date: Fri, 19 Jul 2019 08:53:42 -0700
Subject: [PATCH 1/2] Remove pmd.xml

We are using google-java-format for code formatting/linting.
---
 pmd.xml | 300 --------------------------------------------------------
 1 file changed, 300 deletions(-)
 delete mode 100644 pmd.xml

diff --git a/pmd.xml b/pmd.xml
deleted file mode 100644
index 62a87e6d063a..000000000000
--- a/pmd.xml
+++ /dev/null
@@ -1,300 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<ruleset xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
-         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         name="pmd"
-         xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
-	 <description>PMD Plugin preferences rule set</description>
-	 <exclude-pattern>.*/test/.*</exclude-pattern>
-   <rule ref="rulesets/java/design.xml/AbstractClassWithoutAbstractMethod"/>
-   <rule ref="rulesets/java/design.xml/AbstractClassWithoutAnyMethod"/>
-   <rule ref="rulesets/java/optimizations.xml/AddEmptyString"/>
-   <rule ref="rulesets/java/strings.xml/AppendCharacterWithChar"/>
-   <rule ref="rulesets/java/sunsecure.xml/ArrayIsStoredDirectly"/>
-   <rule ref="rulesets/java/design.xml/AssignmentToNonFinalStatic"/>
-   <rule ref="rulesets/java/controversial.xml/AvoidAccessibilityAlteration"/>
-   <rule ref="rulesets/java/optimizations.xml/AvoidArrayLoops"/>
-   <rule ref="rulesets/java/migrating.xml/AvoidAssertAsIdentifier"/>
-   <rule ref="rulesets/xsl/xpath.xml/AvoidAxisNavigation"/>
-   <rule ref="rulesets/java/basic.xml/AvoidBranchingStatementAsLastInLoop"/>
-   <rule ref="rulesets/java/finalizers.xml/AvoidCallingFinalize"/>
-   <rule ref="rulesets/java/strictexception.xml/AvoidCatchingNPE"/>
-   <rule ref="rulesets/java/strictexception.xml/AvoidCatchingThrowable"/>
-   <rule ref="rulesets/java/design.xml/AvoidConstantsInterface"/>
-   <rule ref="rulesets/java/basic.xml/AvoidDecimalLiteralsInBigDecimalConstructor"/>
-   <rule ref="rulesets/java/design.xml/AvoidDeeplyNestedIfStmts"/>
-   <rule ref="rulesets/vm/basic.xml/AvoidDeeplyNestedIfStmts"/>
-   <rule ref="rulesets/java/naming.xml/AvoidDollarSigns"/>
-   <rule ref="rulesets/java/strings.xml/AvoidDuplicateLiterals"/>
-   <rule ref="rulesets/java/migrating.xml/AvoidEnumAsIdentifier"/>
-   <rule ref="rulesets/java/controversial.xml/AvoidFinalLocalVariable"/>
-   <rule ref="rulesets/java/design.xml/AvoidInstanceofChecksInCatchClause"/>
-   <rule ref="rulesets/java/strictexception.xml/AvoidLosingExceptionInformation"/>
-   <rule ref="rulesets/java/basic.xml/AvoidMultipleUnaryOperators"/>
-   <rule ref="rulesets/java/controversial.xml/AvoidPrefixingMethodParameters"/>
-   <rule ref="rulesets/java/logging-java.xml/AvoidPrintStackTrace"/>
-   <rule ref="rulesets/java/design.xml/AvoidProtectedFieldInFinalClass"/>
-   <rule ref="rulesets/java/design.xml/AvoidProtectedMethodInFinalClassNotExtending"/>
-   <rule ref="rulesets/java/design.xml/AvoidReassigningParameters"/>
-   <rule ref="rulesets/vm/basic.xml/AvoidReassigningParameters"/>
-   <rule ref="rulesets/java/strictexception.xml/AvoidRethrowingException"/>
-   <rule ref="rulesets/java/strings.xml/AvoidStringBufferField"/>
-   <rule ref="rulesets/java/design.xml/AvoidSynchronizedAtMethodLevel"/>
-   <rule ref="rulesets/java/basic.xml/AvoidThreadGroup"/>
-   <rule ref="rulesets/java/strictexception.xml/AvoidThrowingNewInstanceOfSameException"/>
-   <rule ref="rulesets/java/strictexception.xml/AvoidThrowingNullPointerException"/>
-   <rule ref="rulesets/java/strictexception.xml/AvoidThrowingRawExceptionTypes"/>
-   <rule ref="rulesets/ecmascript/basic.xml/AvoidTrailingComma"/>
-   <rule ref="rulesets/java/basic.xml/AvoidUsingHardCodedIP"/>
-   <rule ref="rulesets/java/controversial.xml/AvoidUsingNativeCode"/>
-   <rule ref="rulesets/java/basic.xml/AvoidUsingOctalValues"/>
-   <rule ref="rulesets/java/controversial.xml/AvoidUsingShortType"/>
-   <rule ref="rulesets/java/controversial.xml/AvoidUsingVolatile"/>
-   <rule ref="rulesets/java/design.xml/BadComparison"/>
-   <rule ref="rulesets/java/basic.xml/BigIntegerInstantiation"/>
-   <rule ref="rulesets/java/naming.xml/BooleanGetMethodName"/>
-   <rule ref="rulesets/java/basic.xml/BooleanInstantiation"/>
-   <rule ref="rulesets/java/controversial.xml/BooleanInversion"/>
-   <rule ref="rulesets/java/basic.xml/BrokenNullCheck"/>
-   <rule ref="rulesets/java/migrating.xml/ByteInstantiation"/>
-   <rule ref="rulesets/java/android.xml/CallSuperFirst"/>
-   <rule ref="rulesets/java/android.xml/CallSuperLast"/>
-   <rule ref="rulesets/java/basic.xml/CheckResultSet"/>
-   <rule ref="rulesets/java/basic.xml/CheckSkipResult"/>
-   <rule ref="rulesets/java/basic.xml/ClassCastExceptionWithToArray"/>
-   <rule ref="rulesets/java/naming.xml/ClassNamingConventions"/>
-   <rule ref="rulesets/java/design.xml/ClassWithOnlyPrivateConstructorsShouldBeFinal"/>
-   <rule ref="rulesets/java/clone.xml/CloneMethodMustImplementCloneable"/>
-   <rule ref="rulesets/java/clone.xml/CloneThrowsCloneNotSupportedException"/>
-   <rule ref="rulesets/java/design.xml/CloseResource"/>
-   <rule ref="rulesets/java/basic.xml/CollapsibleIfStatements"/>
-   <rule ref="rulesets/vm/basic.xml/CollapsibleIfStatements"/>
-   <rule ref="rulesets/java/comments.xml/CommentContent"/>
-   <rule ref="rulesets/java/design.xml/CompareObjectsWithEquals"/>
-   <rule ref="rulesets/java/strings.xml/ConsecutiveAppendsShouldReuse"/>
-   <rule ref="rulesets/java/strings.xml/ConsecutiveLiteralAppends"/>
-   <rule ref="rulesets/ecmascript/basic.xml/ConsistentReturn"/>
-   <rule ref="rulesets/java/design.xml/ConstructorCallsOverridableMethod"/>
-   <rule ref="rulesets/java/design.xml/DefaultLabelNotLastInSwitchStmt"/>
-   <rule ref="rulesets/java/controversial.xml/DoNotCallGarbageCollectionExplicitly"/>
-   <rule ref="rulesets/java/j2ee.xml/DoNotCallSystemExit"/>
-   <rule ref="rulesets/java/strictexception.xml/DoNotExtendJavaLangError"/>
-   <rule ref="rulesets/java/android.xml/DoNotHardCodeSDCard"/>
-   <rule ref="rulesets/java/strictexception.xml/DoNotThrowExceptionInFinally"/>
-   <rule ref="rulesets/java/j2ee.xml/DoNotUseThreads"/>
-   <rule ref="rulesets/java/basic.xml/DontCallThreadRun"/>
-   <rule ref="rulesets/java/imports.xml/DontImportJavaLang"/>
-   <rule ref="rulesets/java/controversial.xml/DontImportSun"/>
-   <rule ref="rulesets/jsp/basic-jsf.xml/DontNestJsfInJstlIteration"/>
-   <rule ref="rulesets/java/basic.xml/DontUseFloatTypeForLoopIndices"/>
-   <rule ref="rulesets/java/basic.xml/DoubleCheckedLocking"/>
-   <rule ref="rulesets/java/imports.xml/DuplicateImports"/>
-   <rule ref="rulesets/jsp/basic.xml/DuplicateJspImports"/>
-   <rule ref="rulesets/java/finalizers.xml/EmptyFinalizer"/>
-   <rule ref="rulesets/java/empty.xml/EmptyFinallyBlock"/>
-   <rule ref="rulesets/java/empty.xml/EmptyCatchBlock">
-	   <properties>
-		   <property name="allowCommentedBlocks" value="true"/>
-	   </properties>
-   </rule>
-   <rule ref="rulesets/vm/basic.xml/EmptyForeachStmt"/>
-   <rule ref="rulesets/java/empty.xml/EmptyIfStmt"/>
-   <rule ref="rulesets/vm/basic.xml/EmptyIfStmt"/>
-   <rule ref="rulesets/java/empty.xml/EmptyInitializer"/>
-   <rule ref="rulesets/java/design.xml/EmptyMethodInAbstractClassShouldBeAbstract"/>
-   <rule ref="rulesets/java/empty.xml/EmptyStatementBlock"/>
-   <rule ref="rulesets/java/empty.xml/EmptyStatementNotInLoop"/>
-   <rule ref="rulesets/java/empty.xml/EmptyStaticInitializer"/>
-   <rule ref="rulesets/java/empty.xml/EmptySwitchStatements"/>
-   <rule ref="rulesets/java/empty.xml/EmptySynchronizedBlock"/>
-   <rule ref="rulesets/java/empty.xml/EmptyTryBlock"/>
-   <rule ref="rulesets/java/empty.xml/EmptyWhileStmt"/>
-   <rule ref="rulesets/ecmascript/basic.xml/EqualComparison"/>
-   <rule ref="rulesets/java/design.xml/EqualsNull"/>
-   <rule ref="rulesets/java/strictexception.xml/ExceptionAsFlowControl"/>
-   <rule ref="rulesets/java/codesize.xml/ExcessiveClassLength"/>
-   <rule ref="rulesets/java/coupling.xml/ExcessiveImports"/>
-   <rule ref="rulesets/plsql/codesize.xml/ExcessiveMethodLength"/>
-   <rule ref="rulesets/java/codesize.xml/ExcessiveMethodLength"/>
-   <rule ref="rulesets/plsql/codesize.xml/ExcessiveObjectLength"/>
-   <rule ref="rulesets/plsql/codesize.xml/ExcessivePackageBodyLength"/>
-   <rule ref="rulesets/plsql/codesize.xml/ExcessivePackageSpecificationLength"/>
-   <rule ref="rulesets/plsql/codesize.xml/ExcessiveParameterList"/>
-   <rule ref="rulesets/java/codesize.xml/ExcessiveParameterList"/>
-   <rule ref="rulesets/vm/basic.xml/ExcessiveTemplateLength"/>
-   <rule ref="rulesets/plsql/codesize.xml/ExcessiveTypeLength"/>
-   <rule ref="rulesets/java/basic.xml/ExtendsObject"/>
-   <rule ref="rulesets/java/design.xml/FieldDeclarationsShouldBeAtStartOfClass"/>
-   <rule ref="rulesets/java/design.xml/FinalFieldCouldBeStatic"/>
-   <rule ref="rulesets/java/finalizers.xml/FinalizeDoesNotCallSuperFinalize"/>
-   <rule ref="rulesets/java/finalizers.xml/FinalizeOnlyCallsSuperFinalize"/>
-   <rule ref="rulesets/java/finalizers.xml/FinalizeOverloaded"/>
-   <rule ref="rulesets/java/finalizers.xml/FinalizeShouldBeProtected"/>
-   <rule ref="rulesets/java/basic.xml/ForLoopShouldBeWhileLoop"/>
-   <rule ref="rulesets/java/braces.xml/ForLoopsMustUseBraces"/>
-   <rule ref="rulesets/ecmascript/braces.xml/ForLoopsMustUseBraces"/>
-   <rule ref="rulesets/java/naming.xml/GenericsNaming"/>
-   <rule ref="rulesets/ecmascript/basic.xml/GlobalVariable"/>
-   <rule ref="rulesets/java/logging-jakarta-commons.xml/GuardDebugLogging"/>
-   <rule ref="rulesets/java/logging-jakarta-commons.xml/GuardLogStatement"/>
-   <rule ref="rulesets/java/design.xml/IdempotentOperations"/>
-   <rule ref="rulesets/java/braces.xml/IfElseStmtsMustUseBraces"/>
-   <rule ref="rulesets/ecmascript/braces.xml/IfElseStmtsMustUseBraces"/>
-   <rule ref="rulesets/java/braces.xml/IfStmtsMustUseBraces"/>
-   <rule ref="rulesets/ecmascript/braces.xml/IfStmtsMustUseBraces"/>
-   <rule ref="rulesets/jsp/basic.xml/IframeMissingSrcAttribute"/>
-   <rule ref="rulesets/java/design.xml/ImmutableField"/>
-   <rule ref="rulesets/java/imports.xml/ImportFromSamePackage"/>
-   <rule ref="rulesets/java/strings.xml/InefficientEmptyStringCheck"/>
-   <rule ref="rulesets/java/strings.xml/InefficientStringBuffering"/>
-   <rule ref="rulesets/ecmascript/basic.xml/InnaccurateNumericLiteral"/>
-   <rule ref="rulesets/java/design.xml/InstantiationToGetClass"/>
-   <rule ref="rulesets/java/strings.xml/InsufficientStringBufferDeclaration"/>
-   <rule ref="rulesets/java/migrating.xml/IntegerInstantiation"/>
-   <rule ref="rulesets/java/migrating.xml/JUnit4SuitesShouldUseSuiteAnnotation"/>
-   <rule ref="rulesets/java/migrating.xml/JUnit4TestShouldUseAfterAnnotation"/>
-   <rule ref="rulesets/java/migrating.xml/JUnit4TestShouldUseBeforeAnnotation"/>
-   <rule ref="rulesets/java/migrating.xml/JUnit4TestShouldUseTestAnnotation"/>
-   <rule ref="rulesets/java/junit.xml/JUnitSpelling"/>
-   <rule ref="rulesets/java/junit.xml/JUnitStaticSuite"/>
-   <rule ref="rulesets/java/junit.xml/JUnitTestsShouldIncludeAssert"/>
-   <rule ref="rulesets/jsp/basic.xml/JspEncoding"/>
-   <rule ref="rulesets/java/basic.xml/JumbledIncrementer"/>
-   <rule ref="rulesets/java/j2ee.xml/LocalHomeNamingConvention"/>
-   <rule ref="rulesets/java/j2ee.xml/LocalInterfaceSessionNamingConvention"/>
-   <rule ref="rulesets/java/logging-java.xml/LoggerIsNotStaticFinal"/>
-   <rule ref="rulesets/java/design.xml/LogicInversion"/>
-   <rule ref="rulesets/java/migrating.xml/LongInstantiation"/>
-   <rule ref="rulesets/java/coupling.xml/LooseCoupling"/>
-   <rule ref="rulesets/java/coupling.xml/LoosePackageCoupling"/>
-   <rule ref="rulesets/java/j2ee.xml/MDBAndSessionBeanNamingConvention"/>
-   <rule ref="rulesets/java/naming.xml/MethodNamingConventions"/>
-   <rule ref="rulesets/java/sunsecure.xml/MethodReturnsInternalArray"/>
-   <rule ref="rulesets/java/naming.xml/MethodWithSameNameAsEnclosingClass"/>
-   <rule ref="rulesets/java/naming.xml/MisleadingVariableName"/>
-   <rule ref="rulesets/java/basic.xml/MisplacedNullCheck"/>
-   <rule ref="rulesets/java/design.xml/MissingBreakInSwitch"/>
-   <rule ref="rulesets/java/javabeans.xml/MissingSerialVersionUID"/>
-   <rule ref="rulesets/java/design.xml/MissingStaticMethodInNonInstantiatableClass"/>
-   <rule ref="rulesets/xml/basic.xml/MistypedCDATASection"/>
-   <rule ref="rulesets/java/logging-java.xml/MoreThanOneLogger"/>
-   <rule ref="rulesets/java/codesize.xml/NcssConstructorCount"/>
-   <rule ref="rulesets/plsql/codesize.xml/NcssMethodCount"/>
-   <rule ref="rulesets/java/codesize.xml/NcssMethodCount"/>
-   <rule ref="rulesets/plsql/codesize.xml/NcssObjectCount"/>
-   <rule ref="rulesets/java/codesize.xml/NcssTypeCount"/>
-   <rule ref="rulesets/jsp/basic.xml/NoClassAttribute"/>
-   <rule ref="rulesets/jsp/basic.xml/NoHtmlComments"/>
-   <rule ref="rulesets/vm/basic.xml/NoInlineJavaScript"/>
-   <rule ref="rulesets/jsp/basic.xml/NoInlineScript"/>
-   <rule ref="rulesets/jsp/basic.xml/NoInlineStyleInformation"/>
-   <rule ref="rulesets/vm/basic.xml/NoInlineStyles"/>
-   <rule ref="rulesets/jsp/basic.xml/NoJspForward"/>
-   <rule ref="rulesets/jsp/basic.xml/NoLongScripts"/>
-   <rule ref="rulesets/java/naming.xml/NoPackage"/>
-   <rule ref="rulesets/jsp/basic.xml/NoScriptlets"/>
-   <rule ref="rulesets/jsp/basic.xml/NoUnsanitizedJSPExpression"/>
-   <rule ref="rulesets/java/design.xml/NonCaseLabelInSwitchStatement"/>
-   <rule ref="rulesets/java/design.xml/NonStaticInitializer"/>
-   <rule ref="rulesets/java/design.xml/NonThreadSafeSingleton"/>
-   <rule ref="rulesets/java/controversial.xml/OneDeclarationPerLine"/>
-   <rule ref="rulesets/java/design.xml/OptimizableToArrayCall"/>
-   <rule ref="rulesets/java/basic.xml/OverrideBothEqualsAndHashcode"/>
-   <rule ref="rulesets/java/naming.xml/PackageCase"/>
-   <rule ref="rulesets/java/design.xml/PositionLiteralsFirstInCaseInsensitiveComparisons"/>
-   <rule ref="rulesets/java/design.xml/PositionLiteralsFirstInComparisons"/>
-   <rule ref="rulesets/java/optimizations.xml/PrematureDeclaration"/>
-   <rule ref="rulesets/java/design.xml/PreserveStackTrace"/>
-   <rule ref="rulesets/java/clone.xml/ProperCloneImplementation"/>
-   <rule ref="rulesets/java/logging-jakarta-commons.xml/ProperLogger"/>
-   <rule ref="rulesets/java/optimizations.xml/RedundantFieldInitializer"/>
-   <rule ref="rulesets/java/j2ee.xml/RemoteInterfaceNamingConvention"/>
-   <rule ref="rulesets/java/j2ee.xml/RemoteSessionInterfaceNamingConvention"/>
-   <rule ref="rulesets/java/migrating.xml/ReplaceEnumerationWithIterator"/>
-   <rule ref="rulesets/java/migrating.xml/ReplaceHashtableWithMap"/>
-   <rule ref="rulesets/java/migrating.xml/ReplaceVectorWithList"/>
-   <rule ref="rulesets/java/design.xml/ReturnEmptyArrayRatherThanNull"/>
-   <rule ref="rulesets/java/basic.xml/ReturnFromFinallyBlock"/>
-   <rule ref="rulesets/ecmascript/basic.xml/ScopeForInVariable"/>
-   <rule ref="rulesets/java/naming.xml/ShortClassName">
-	   <properties>
-		   <property name="minimum" value="3"/>
-	   </properties>
-   </rule>
-   <rule ref="rulesets/java/migrating.xml/ShortInstantiation"/>
-   <rule ref="rulesets/java/strictexception.xml/SignatureDeclareThrowsException"/>
-   <rule ref="rulesets/java/design.xml/SimpleDateFormatNeedsLocale"/>
-   <rule ref="rulesets/java/junit.xml/SimplifyBooleanAssertion"/>
-   <rule ref="rulesets/java/design.xml/SimplifyBooleanExpressions"/>
-   <rule ref="rulesets/java/design.xml/SimplifyBooleanReturns"/>
-   <rule ref="rulesets/java/design.xml/SimplifyConditional"/>
-   <rule ref="rulesets/java/optimizations.xml/SimplifyStartsWith"/>
-   <rule ref="rulesets/java/design.xml/SingularField"/>
-   <rule ref="rulesets/java/j2ee.xml/StaticEJBFieldShouldBeFinal"/>
-   <rule ref="rulesets/java/strings.xml/StringBufferInstantiationWithChar"/>
-   <rule ref="rulesets/java/strings.xml/StringInstantiation"/>
-   <rule ref="rulesets/java/strings.xml/StringToString"/>
-   <rule ref="rulesets/java/naming.xml/SuspiciousConstantFieldName"/>
-   <rule ref="rulesets/java/naming.xml/SuspiciousEqualsMethodName"/>
-   <rule ref="rulesets/java/naming.xml/SuspiciousHashcodeMethodName"/>
-   <rule ref="rulesets/java/controversial.xml/SuspiciousOctalEscape"/>
-   <rule ref="rulesets/java/design.xml/SwitchDensity"/>
-   <rule ref="rulesets/java/design.xml/SwitchStmtsShouldHaveDefault"/>
-   <rule ref="rulesets/java/logging-java.xml/SystemPrintln"/>
-   <rule ref="rulesets/plsql/dates.xml/TO_DATEWithoutDateFormat"/>
-   <rule ref="rulesets/plsql/dates.xml/TO_DATE_TO_CHAR"/>
-   <rule ref="rulesets/plsql/dates.xml/TO_TIMESTAMPWithoutDateFormat"/>
-   <rule ref="rulesets/java/junit.xml/TestClassWithoutTestCases"/>
-   <rule ref="rulesets/plsql/TomKytesDespair.xml/TomKytesDespair"/>
-   <rule ref="rulesets/java/design.xml/TooFewBranchesForASwitchStatement"/>
-   <rule ref="rulesets/plsql/codesize.xml/TooManyFields"/>
-   <rule ref="rulesets/java/codesize.xml/TooManyFields"/>
-   <rule ref="rulesets/plsql/codesize.xml/TooManyMethods"/>
-   <rule ref="rulesets/java/design.xml/UncommentedEmptyMethod"/>
-   <rule ref="rulesets/java/basic.xml/UnconditionalIfStatement"/>
-   <rule ref="rulesets/ecmascript/unnecessary.xml/UnnecessaryBlock"/>
-   <rule ref="rulesets/java/junit.xml/UnnecessaryBooleanAssertion"/>
-   <rule ref="rulesets/java/strings.xml/UnnecessaryCaseChange"/>
-   <rule ref="rulesets/java/controversial.xml/UnnecessaryConstructor"/>
-   <rule ref="rulesets/java/basic.xml/UnnecessaryConversionTemporary"/>
-   <rule ref="rulesets/java/basic.xml/UnnecessaryFinalModifier"/>
-   <rule ref="rulesets/java/imports.xml/UnnecessaryFullyQualifiedName"/>
-   <rule ref="rulesets/java/design.xml/UnnecessaryLocalBeforeReturn"/>
-   <rule ref="rulesets/ecmascript/unnecessary.xml/UnnecessaryParentheses"/>
-   <rule ref="rulesets/java/controversial.xml/UnnecessaryParentheses"/>
-   <rule ref="rulesets/java/basic.xml/UnnecessaryReturn"/>
-   <rule ref="rulesets/java/optimizations.xml/UnnecessaryWrapperObjectCreation"/>
-   <rule ref="rulesets/ecmascript/basic.xml/UnreachableCode"/>
-   <rule ref="rulesets/java/design.xml/UnsynchronizedStaticDateFormatter"/>
-   <rule ref="rulesets/java/unusedcode.xml/UnusedFormalParameter"/>
-   <rule ref="rulesets/java/imports.xml/UnusedImports"/>
-   <rule ref="rulesets/java/unusedcode.xml/UnusedLocalVariable"/>
-   <rule ref="rulesets/vm/basic.xml/UnusedMacroParameter"/>
-   <rule ref="rulesets/java/unusedcode.xml/UnusedModifier"/>
-   <rule ref="rulesets/java/basic.xml/UnusedNullCheckInEquals"/>
-   <rule ref="rulesets/java/unusedcode.xml/UnusedPrivateField"/>
-   <rule ref="rulesets/java/unusedcode.xml/UnusedPrivateMethod"/>
-   <rule ref="rulesets/java/optimizations.xml/UseArrayListInsteadOfVector"/>
-   <rule ref="rulesets/java/optimizations.xml/UseArraysAsList"/>
-   <rule ref="rulesets/java/junit.xml/UseAssertEqualsInsteadOfAssertTrue"/>
-   <rule ref="rulesets/java/junit.xml/UseAssertNullInsteadOfAssertTrue"/>
-   <rule ref="rulesets/java/junit.xml/UseAssertSameInsteadOfAssertTrue"/>
-   <rule ref="rulesets/java/junit.xml/UseAssertTrueInsteadOfAssertEquals"/>
-   <rule ref="rulesets/ecmascript/basic.xml/UseBaseWithParseInt"/>
-   <rule ref="rulesets/java/design.xml/UseCollectionIsEmpty"/>
-   <rule ref="rulesets/xsl/xpath.xml/UseConcatOnce"/>
-   <rule ref="rulesets/java/logging-jakarta-commons.xml/UseCorrectExceptionLogging"/>
-   <rule ref="rulesets/java/strings.xml/UseEqualsToCompareStrings"/>
-   <rule ref="rulesets/java/strings.xml/UseIndexOfChar"/>
-   <rule ref="rulesets/java/design.xml/UseLocaleWithCaseConversions"/>
-   <rule ref="rulesets/java/design.xml/UseNotifyAllInsteadOfNotify"/>
-   <rule ref="rulesets/java/controversial.xml/UseObjectForClearerAPI"/>
-   <rule ref="rulesets/java/j2ee.xml/UseProperClassLoader"/>
-   <rule ref="rulesets/java/optimizations.xml/UseStringBufferForStringAppends"/>
-   <rule ref="rulesets/java/strings.xml/UseStringBufferLength"/>
-   <rule ref="rulesets/java/design.xml/UseUtilityClass"/>
-   <rule ref="rulesets/java/basic.xml/UselessOperationOnImmutable"/>
-   <rule ref="rulesets/java/basic.xml/UselessParentheses"/>
-   <rule ref="rulesets/java/strings.xml/UselessStringValueOf"/>
-   <rule ref="rulesets/java/braces.xml/WhileLoopsMustUseBraces"/>
-   <rule ref="rulesets/ecmascript/braces.xml/WhileLoopsMustUseBraces"/>
-</ruleset>

From b5f61b9d894f46503b10534db13cfc3323e2a3bf Mon Sep 17 00:00:00 2001
From: Jeff Ching <chingor@google.com>
Date: Fri, 19 Jul 2019 10:43:22 -0700
Subject: [PATCH 2/2] Remove .eclipse-pmd file

---
 .eclipse-pmd | 7 -------
 1 file changed, 7 deletions(-)
 delete mode 100644 .eclipse-pmd

diff --git a/.eclipse-pmd b/.eclipse-pmd
deleted file mode 100644
index 5b4a4cb75170..000000000000
--- a/.eclipse-pmd
+++ /dev/null
@@ -1,7 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<eclipse-pmd xmlns="http://acanda.ch/eclipse-pmd/0.8" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://acanda.ch/eclipse-pmd/0.8 http://acanda.ch/eclipse-pmd/eclipse-pmd-0.8.xsd">
-  <analysis enabled="true" />
-  <rulesets>
-    <ruleset name="Project PMD settings" ref="pmd.xml" refcontext="project" />
-  </rulesets>
-</eclipse-pmd>
\ No newline at end of file