Skip to content

Commit dc9ed41

Browse files
authored
Remove ClientLogin (#1224)
* Remove ClientLogin * Bump clirr comparison version and note that we are removing beta classes
1 parent 2079c4c commit dc9ed41

7 files changed

Lines changed: 19 additions & 465 deletions

File tree

clirr-ignored-differences.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,8 @@
22
<!-- see http://mojo.codehaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
33

44
<differences>
5+
<difference>
6+
<differenceType>8001</differenceType>
7+
<className>com/google/api/client/googleapis/auth/clientlogin/**</className>
8+
</difference>
59
</differences>

findbugs-exclude.xml

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,23 +6,18 @@
66
<LastVersion value="-1" relOp="NEQ"/>
77
<!-- The following have not yet been investigated -->
88

9-
<!-- The following are known to be bugs and should be fixed -->
10-
<And>
11-
<Package name="com.google.api.client.googleapis.auth.clientlogin"/>
12-
</And>
13-
149
<!-- The following are known to NOT be bugs and should not be fixed -->
1510
<And>
16-
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
17-
<!-- Class doesn't override equals in superclass -->
11+
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
12+
<!-- Class doesn't override equals in superclass -->
1813
<Class name="com.google.api.client.googleapis.auth.oauth2.GoogleAuthorizationCodeRequestUrl"/>
1914
</And>
2015
<And>
21-
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
16+
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
2217
<Class name="com.google.api.client.googleapis.auth.oauth2.GoogleBrowserClientRequestUrl"/>
2318
</And>
2419
<And>
25-
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
20+
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
2621
<Class name="com.google.api.client.googleapis.GoogleUrl"/>
2722
</And>
2823
<And>
@@ -88,26 +83,26 @@
8883
<And>
8984
<Bug pattern="DM_STRING_CTOR"/>
9085
<!-- Method invokes inefficient new String(String) constructor -->
91-
<Class name="com.google.api.client.googleapis.batch.BatchRequest"/>
92-
</And>
86+
<Class name="com.google.api.client.googleapis.batch.BatchRequest"/>
87+
</And>
9388
<And>
9489
<Bug pattern="DM_STRING_CTOR"/>
9590
<!-- Method invokes inefficient new String(String) constructor -->
96-
<Class name="com.google.api.client.googleapis.services.AbstractGoogleClient"/>
97-
</And>
91+
<Class name="com.google.api.client.googleapis.services.AbstractGoogleClient"/>
92+
</And>
9893
<And>
9994
<Bug pattern="DM_STRING_CTOR"/>
10095
<!-- Method invokes inefficient new String(String) constructor -->
101-
<Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential"/>
102-
</And>
96+
<Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential"/>
97+
</And>
10398
<And>
10499
<Bug pattern="DM_STRING_CTOR"/>
105100
<!-- Method invokes inefficient new String(String) constructor -->
106-
<Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential$RequestHandler"/>
107-
</And>
101+
<Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential$RequestHandler"/>
102+
</And>
108103
<And>
109104
<Bug pattern="DM_STRING_CTOR"/>
110105
<!-- Method invokes inefficient new String(String) constructor -->
111-
<Class name="com.google.api.client.googleapis.xml.atom.MultiKindFeedParser"/>
112-
</And>
106+
<Class name="com.google.api.client.googleapis.xml.atom.MultiKindFeedParser"/>
107+
</And>
113108
</FindBugsFilter>

google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/AuthKeyValueParser.java

Lines changed: 0 additions & 156 deletions
This file was deleted.

0 commit comments

Comments
 (0)