Skip to content

Commit 117370b

Browse files
[dead-code] chore: remove dead functions — 1 function removed (#43397)
1 parent 9a1d55b commit 117370b

4 files changed

Lines changed: 1513 additions & 1543 deletions

File tree

docs/adr/43345-templatable-bool-or-int-type-for-config-fields.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ We decided to introduce a new string-backed type `TemplatableBoolOrInt` in `pkg/
1818

1919
#### Alternative 1: Keep `any` type and add post-parse type-switch conversion
2020

21-
The `AddBoolOrInt` builder method already performs a type-switch on `any` values to emit booleans or integers. The emission bug could have been fixed by simply wiring `DeduplicateByTitle` into `AddBoolOrInt` without changing the field type. However, `any` carries no type constraints at parse time, so schema validation alone blocks expression strings from entering the field. Expression strings would have required additional ad-hoc handling that bypasses the type system and is invisible in struct definitions.
21+
At the time, the `AddBoolOrInt` builder method performed a type-switch on `any` values to emit booleans or integers. The emission bug could have been fixed by simply wiring `DeduplicateByTitle` into `AddBoolOrInt` without changing the field type. However, `any` carries no type constraints at parse time, so schema validation alone blocks expression strings from entering the field. Expression strings would have required additional ad-hoc handling that bypasses the type system and is invisible in struct definitions.
2222

2323
#### Alternative 2: Explicit union struct (`struct { Bool *bool; Int *int; Expr *string }`)
2424

0 commit comments

Comments
 (0)