From 45fcc54027d7cdb079d025a7c01b04f62235adae Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Sat, 6 Jun 2026 23:49:15 +0000 Subject: [PATCH 1/2] Add debug logging to HTTP server lifecycle in serve.go MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add 5 meaningful debug log calls to the serveAndWait function using the existing package-level debugLog logger. These log server startup, unexpected exits, shutdown signal receipt, graceful shutdown failures, and successful graceful shutdown — all key lifecycle events that aid in troubleshooting server startup and shutdown behaviour. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- internal/cmd/serve.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/internal/cmd/serve.go b/internal/cmd/serve.go index fb3a89ee..fc4e5903 100644 --- a/internal/cmd/serve.go +++ b/internal/cmd/serve.go @@ -20,16 +20,19 @@ func serveAndWait( onShutdownSignal func(), serveFn func() error, ) error { + debugLog.Printf("Starting HTTP server: addr=%s, shutdownTimeout=%s", httpServer.Addr, timeout) serveErrCh := make(chan error, 1) go func() { err := serveFn() if err != nil && !errors.Is(err, http.ErrServerClosed) { + debugLog.Printf("HTTP server exited unexpectedly, triggering shutdown: %v", err) cancel() } serveErrCh <- err }() <-ctx.Done() + debugLog.Print("Shutdown signal received, beginning graceful HTTP server shutdown") if onShutdownSignal != nil { onShutdownSignal() } @@ -39,6 +42,7 @@ func serveAndWait( shutdownErr := httpServer.Shutdown(shutdownCtx) if shutdownErr != nil { + debugLog.Printf("Graceful shutdown failed, forcing close: %v", shutdownErr) _ = httpServer.Close() select { case <-serveErrCh: @@ -47,6 +51,7 @@ func serveAndWait( return shutdownErr } + debugLog.Print("HTTP server shut down gracefully") serveErr := <-serveErrCh if serveErr != nil && !errors.Is(serveErr, http.ErrServerClosed) { return serveErr From 242c4c3bc44a2d595c7fb35e01edbe878b1176af Mon Sep 17 00:00:00 2001 From: Landon Cox Date: Sun, 7 Jun 2026 10:01:57 -0700 Subject: [PATCH 2/2] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- internal/cmd/serve.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/cmd/serve.go b/internal/cmd/serve.go index fc4e5903..aaa15c75 100644 --- a/internal/cmd/serve.go +++ b/internal/cmd/serve.go @@ -32,7 +32,7 @@ func serveAndWait( }() <-ctx.Done() - debugLog.Print("Shutdown signal received, beginning graceful HTTP server shutdown") + debugLog.Print("Shutdown initiated, beginning graceful HTTP server shutdown") if onShutdownSignal != nil { onShutdownSignal() }