Simplify creation of PagedIterables from requests#563
Merged
bitwiseman merged 3 commits intohub4j:masterfrom Oct 11, 2019
Merged
Simplify creation of PagedIterables from requests#563bitwiseman merged 3 commits intohub4j:masterfrom
bitwiseman merged 3 commits intohub4j:masterfrom
Conversation
d58f4d1 to
2fba184
Compare
Member
Author
|
@martinvanzijl |
Contributor
|
@bitwiseman Do you want me to do a formal review on GitHub? If so, just that one change for |
Member
Author
|
@martinvanzijl You've submitted a bunch of PRs and made tests. I feel you're familiar enough with the project to do that in a meaningful way. Thanks! |
4838607 to
281c927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change eliminates a whole bunch of cruft from the creation of PagedIterables. Dependent on Java 8+ closures.