Skip to content

GitHub workflow: enable Java matrix [ '1.8.0', '11.0.x' ]#562

Merged
bitwiseman merged 3 commits intohub4j:masterfrom
sullis:github-workflow-java-matrix
Oct 8, 2019
Merged

GitHub workflow: enable Java matrix [ '1.8.0', '11.0.x' ]#562
bitwiseman merged 3 commits intohub4j:masterfrom
sullis:github-workflow-java-matrix

Conversation

@sullis
Copy link
Contributor

@sullis sullis commented Oct 7, 2019

No description provided.

@bitwiseman
Copy link
Member

@sullis
Great idea, but it looks like maybe bridge method facility is not compatible in some way.
We use those to maintain backward compatibility.

It looks like the indexer that would usually create the file to tell the bridge method injector what classes to process isn't running when expected.

I've tried compiling on Java 8 and then running on java 11 and that seems okay. If you can get the annotations I'd be happy to take this PR.

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

@bitwiseman bitwiseman merged commit 2fdc5a8 into hub4j:master Oct 8, 2019
@sullis sullis deleted the github-workflow-java-matrix branch November 25, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants