Skip to content

Fix invalid URL for pull request comments update/delete#182

Merged
kohsuke merged 1 commit intohub4j:masterfrom
henryju:master
Jul 17, 2015
Merged

Fix invalid URL for pull request comments update/delete#182
kohsuke merged 1 commit intohub4j:masterfrom
henryju:master

Conversation

@henryju
Copy link
Contributor

@henryju henryju commented Apr 27, 2015

No description provided.

@buildhive
Copy link

buildhive commented Apr 27, 2015

Kohsuke Kawaguchi » github-api #334 SUCCESS
This pull request looks good
(what's this?)

@KostyaSha
Copy link
Contributor

KostyaSha commented Apr 27, 2015

Some test case will be appreciated

@buildhive
Copy link

buildhive commented Apr 27, 2015

Kohsuke Kawaguchi » github-api #335 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

buildhive commented Apr 27, 2015

Kohsuke Kawaguchi » github-api #336 SUCCESS
This pull request looks good
(what's this?)

@henryju
Copy link
Contributor Author

henryju commented Apr 27, 2015

I have added some integration tests and fixed regression from last commit in master.

@buildhive
Copy link

buildhive commented Apr 27, 2015

Kohsuke Kawaguchi » github-api #337 SUCCESS
This pull request looks good
(what's this?)

@henryju
Copy link
Contributor Author

henryju commented May 6, 2015

Any update about this? Thanks

@oleg-nenashev
Copy link
Collaborator

oleg-nenashev commented May 15, 2015

👍

@buildhive
Copy link

buildhive commented May 22, 2015

Kohsuke Kawaguchi » github-api #344 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

buildhive commented May 22, 2015

Kohsuke Kawaguchi » github-api #345 SUCCESS
This pull request looks good
(what's this?)

KostyaSha
KostyaSha reviewed May 22, 2015
View reviewed changes
pom.xml Outdated
Copy link
Contributor

@KostyaSha KostyaSha May 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Contributor Author

@henryju henryju May 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have updated my own fork without thinking about this open P/R. I'll fix that.

@buildhive
Copy link

buildhive commented May 22, 2015

Kohsuke Kawaguchi » github-api #346 SUCCESS
This pull request looks good
(what's this?)

@henryju
Copy link
Contributor Author

henryju commented Jun 16, 2015

Rebased on master for easier merge.

@buildhive
Copy link

buildhive commented Jun 16, 2015

Kohsuke Kawaguchi » github-api #356 SUCCESS
This pull request looks good
(what's this?)

kohsuke added a commit that referenced this pull request Jul 17, 2015
@kohsuke
Merge pull request #182 from henryju/master
c4113f1 
Fix invalid URL for pull request comments update/delete
@kohsuke kohsuke merged commit c4113f1 into hub4j:master Jul 17, 2015
@kohsuke
Copy link
Collaborator

kohsuke commented Jul 17, 2015

My apologies for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@henryju @buildhive @KostyaSha @oleg-nenashev @kohsuke