getMergeableState in GHPullRequest doesn't work

[Memphiz]

Hi there,

it seems that the GHPullRequest.getMergeableState method doesn't work in current implementation. At least when i use the jenkins ghprb (github pull request builder plugin) it always builds the unmerged branch only because off the method returing false (though the pr is mergeable as confirmed in the github webinterface).

Based on the github api v3 the needed field is called "mergeable" (and a boolean).

It seems that "populate" doesn't fill in the "mergeable_state" member. Though i didn't find the code where it really fills in the object members.

Also it looks like in GHPullRequest.populate() the call to root.retrieve().to(url, this); is issued with an empty url object. At least i didn't spot where the url member (its a member of the parent class GHIssue) is initialised.

Would be great if you could comment on that one :o)

thx

Memphiz

[Memphiz]

This was a false alert. Problem was that the getMergeableState was never called when a comment triggered a build in the ghprb-plugin for jenkins. It works as expected when called ;).

Sorry for the noise.