chore(seer): Setup new, blank, page for Seer settings to live #103990
Conversation
This is all behind a feature flag called "seer-settings-gtm". I tested things by enabling the flag with the toolbar and I can see that urls like /settings/seer/ and /settings/seer/projects/ and /settings/seer/repositories/ show the basic html that is defined. When I toggle the flag off (again, via the toolbar) I can see the "You dont have access to this feature " message as expected. By setting up the flag and the blank pages like this it should be easier to do work in parallel against all three pages, and the original settings page is not affected.
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
This is intentional and safe. We're adding a new flag to the backend and using it in the frontend, the default is off though so no one will be affected. I'm not going to turn on the flag in flagpole to test it out, because people (even me!) need to continue to see the old settings page at the same time, everyone should use the toolbar to test these changes. The flag name is |
| </NoProjectMessage> | ||
| </Fragment> | ||
| ); | ||
| return <Outlet />; |
There was a problem hiding this comment.
All that stuff got moved into seerAutomation.tsx
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103990 +/- ##
===========================================
+ Coverage 75.87% 80.62% +4.74%
===========================================
Files 9308 9312 +4
Lines 397265 397420 +155
Branches 25343 25343
===========================================
+ Hits 301432 320417 +18985
+ Misses 95392 76562 -18830
Partials 441 441 |
This is all behind a feature flag called "seer-settings-gtm". I tested things by enabling the flag with the toolbar and I can see that urls like /settings/seer/ and /settings/seer/projects/ and /settings/seer/repositories/ show the basic html that is defined. When I toggle the flag off (again, via the toolbar) I can see the "You dont have access to this feature " message as expected.
By setting up the flag and the blank pages like this it should be easier to do work in parallel against all three pages, and the original settings page is not affected.
This change has frontend and backend changes because it's adding a new flag. The default for the flag is 'off' so these changes are safe to be merged together, and be deployed at any time in any order.
Look at these screenshots to see the testing in action: