feat: Add url_names option to deprecated() #103758
Merged
+115
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need to deprecate some of the URL names/mount points for APIs as part of the cells project. I've also fixed the default option names, as prior to this change the default deprecation key name would log an exception for every request. For example, to deprecate one of the group-details URLs, we could use: ``` @deprecated(datetime(2026, 2, 28, 0, 0, 0, tzinfo=UTC), url_names=["sentry-api-0-group-details"]) ``` Refs INFRENG-200
markstory
commented
Nov 20, 2025
| except UnknownOption: | ||
| logger.exception("Unrecognized deprecation duration %s", key) | ||
| brownout_duration = options.get("api.deprecation.brownout-duration-seconds") | ||
| brownout_duration = options.get("api.deprecation.brownout-duration") |
Member
Author
There was a problem hiding this comment.
This now matches the default brownout-duration key name. Prior to this, if a deprecated endpoint didn't define key it would log an exception on every request.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103758 +/- ##
===========================================
- Coverage 80.50% 80.47% -0.03%
===========================================
Files 9274 9278 +4
Lines 395963 397289 +1326
Branches 25250 25250
===========================================
+ Hits 318770 319725 +955
- Misses 76764 77135 +371
Partials 429 429 |
nikhars
approved these changes
Nov 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need to deprecate some of the URL names/mount points for APIs as part of the cells project. I've also fixed the default option names, as prior to this change the default deprecation key name would log an exception for every request. For example, to deprecate one of the group-details URLs, we could use:
Refs INFRENG-200