Skip to content

Commit b781f3b

Browse files
ref(feedback): move feedback empty state to /feedback (#103763)
i noticed that there was this user feedback empty state & pathnames file hanging out in `/userFeedback/` by itself, so i moved it with the rest of the feedback components under `/feedback/`.
1 parent 0322b39 commit b781f3b

File tree

11 files changed

+20
-20
lines changed

11 files changed

+20
-20
lines changed

static/app/components/feedback/feedbackItem/feedbackShortId.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {t} from 'sentry/locale';
1313
import type {FeedbackIssue} from 'sentry/utils/feedback/types';
1414
import useCopyToClipboard from 'sentry/utils/useCopyToClipboard';
1515
import useOrganization from 'sentry/utils/useOrganization';
16-
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
16+
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';
1717

1818
interface Props {
1919
feedbackItem: FeedbackIssue;

static/app/components/feedback/list/feedbackListItem.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import useReplayCountForFeedbacks from 'sentry/utils/replayCount/useReplayCountF
2222
import useLocationQuery from 'sentry/utils/url/useLocationQuery';
2323
import {useLocation} from 'sentry/utils/useLocation';
2424
import useOrganization from 'sentry/utils/useOrganization';
25-
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
25+
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';
2626

2727
interface Props {
2828
feedbackItem: FeedbackIssueListItem;

static/app/components/feedback/useDeleteFeedback.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import useApi from 'sentry/utils/useApi';
1010
import {useLocation} from 'sentry/utils/useLocation';
1111
import {useNavigate} from 'sentry/utils/useNavigate';
1212
import useOrganization from 'sentry/utils/useOrganization';
13-
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
13+
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';
1414

1515
export const useDeleteFeedback = (feedbackIds: any, projectId: any) => {
1616
const organization = useOrganization();

static/app/components/feedback/useRedirectToFeedbackFromEvent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {decodeScalar} from 'sentry/utils/queryString';
66
import useLocationQuery from 'sentry/utils/url/useLocationQuery';
77
import {useNavigate} from 'sentry/utils/useNavigate';
88
import useOrganization from 'sentry/utils/useOrganization';
9-
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
9+
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';
1010

1111
export default function useRedirectToFeedbackFromEvent() {
1212
const organization = useOrganization();

static/app/components/replays/breadcrumbs/breadcrumbIssueLink.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import type {ErrorFrame, FeedbackFrame, ReplayFrame} from 'sentry/utils/replays/
88
import {isErrorFrame, isFeedbackFrame} from 'sentry/utils/replays/types';
99
import useOrganization from 'sentry/utils/useOrganization';
1010
import useProjectFromSlug from 'sentry/utils/useProjectFromSlug';
11-
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
11+
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';
1212

1313
interface Props {
1414
frame: ReplayFrame;

static/app/views/alerts/rules/issue/details/issuesList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {getMessage, getTitle} from 'sentry/utils/events';
1818
import type {FeedbackIssue} from 'sentry/utils/feedback/types';
1919
import {useApiQuery} from 'sentry/utils/queryClient';
2020
import useOrganization from 'sentry/utils/useOrganization';
21-
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
21+
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';
2222

2323
type GroupHistory = {
2424
count: number;

static/app/views/userFeedback/userFeedbackEmpty.spec.tsx renamed to static/app/views/feedback/feedbackEmptyState.spec.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,21 @@ import {ProjectFixture} from 'sentry-fixture/project';
33
import {act, render, screen} from 'sentry-test/reactTestingLibrary';
44

55
import ProjectsStore from 'sentry/stores/projectsStore';
6-
import {UserFeedbackEmpty} from 'sentry/views/userFeedback/userFeedbackEmpty';
6+
import {FeedbackEmptyState} from 'sentry/views/feedback/feedbackEmptyState';
77

8-
describe('UserFeedbackEmpty', () => {
8+
describe('FeedbackEmptyState', () => {
99
const project = ProjectFixture({id: '1'});
1010
const projectWithReports = ProjectFixture({id: '2', hasUserReports: true});
1111
const projectWithoutReports = ProjectFixture({id: '3'});
1212

1313
it('renders empty', () => {
14-
render(<UserFeedbackEmpty />);
14+
render(<FeedbackEmptyState />);
1515
});
1616

1717
it('renders landing for project with no user feedback', () => {
1818
act(() => ProjectsStore.loadInitialData([project]));
1919

20-
render(<UserFeedbackEmpty />);
20+
render(<FeedbackEmptyState />);
2121

2222
expect(
2323
screen.getByRole('heading', {name: 'What do users think?'})
@@ -27,7 +27,7 @@ describe('UserFeedbackEmpty', () => {
2727
it('renders warning for project with any user feedback', () => {
2828
act(() => ProjectsStore.loadInitialData([projectWithReports]));
2929

30-
render(<UserFeedbackEmpty />);
30+
render(<FeedbackEmptyState />);
3131

3232
expect(
3333
screen.getByText('Sorry, no user reports match your filters.')
@@ -37,7 +37,7 @@ describe('UserFeedbackEmpty', () => {
3737
it('renders warning for projects with any user feedback', () => {
3838
act(() => ProjectsStore.loadInitialData([project, projectWithReports]));
3939

40-
render(<UserFeedbackEmpty />);
40+
render(<FeedbackEmptyState />);
4141

4242
expect(
4343
screen.getByText('Sorry, no user reports match your filters.')
@@ -47,7 +47,7 @@ describe('UserFeedbackEmpty', () => {
4747
it('renders warning for project query with user feedback', () => {
4848
act(() => ProjectsStore.loadInitialData([project, projectWithReports]));
4949

50-
render(<UserFeedbackEmpty projectIds={[projectWithReports.id]} />);
50+
render(<FeedbackEmptyState projectIds={[projectWithReports.id]} />);
5151

5252
expect(
5353
screen.getByText('Sorry, no user reports match your filters.')
@@ -57,7 +57,7 @@ describe('UserFeedbackEmpty', () => {
5757
it('renders landing for project query without any user feedback', () => {
5858
act(() => ProjectsStore.loadInitialData([project, projectWithReports]));
5959

60-
render(<UserFeedbackEmpty projectIds={[project.id]} />);
60+
render(<FeedbackEmptyState projectIds={[project.id]} />);
6161

6262
expect(
6363
screen.getByRole('heading', {name: 'What do users think?'})
@@ -67,7 +67,7 @@ describe('UserFeedbackEmpty', () => {
6767
it('renders warning for multi project query with any user feedback', () => {
6868
act(() => ProjectsStore.loadInitialData([project, projectWithReports]));
6969

70-
render(<UserFeedbackEmpty projectIds={[project.id, projectWithReports.id]} />);
70+
render(<FeedbackEmptyState projectIds={[project.id, projectWithReports.id]} />);
7171

7272
expect(
7373
screen.getByText('Sorry, no user reports match your filters.')
@@ -77,7 +77,7 @@ describe('UserFeedbackEmpty', () => {
7777
it('renders landing for multi project query without any user feedback', () => {
7878
act(() => ProjectsStore.loadInitialData([project, projectWithoutReports]));
7979

80-
render(<UserFeedbackEmpty projectIds={[project.id, projectWithoutReports.id]} />);
80+
render(<FeedbackEmptyState projectIds={[project.id, projectWithoutReports.id]} />);
8181

8282
expect(
8383
screen.getByRole('heading', {name: 'What do users think?'})

static/app/views/userFeedback/userFeedbackEmpty.tsx renamed to static/app/views/feedback/feedbackEmptyState.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ type Props = {
2121
projectIds?: string[];
2222
};
2323

24-
export function UserFeedbackEmpty({projectIds, issueTab = false}: Props) {
24+
export function FeedbackEmptyState({projectIds, issueTab = false}: Props) {
2525
const {projects, initiallyLoaded} = useProjects();
2626
const loadingProjects = !initiallyLoaded;
2727
const organization = useOrganization();
File renamed without changes.

static/app/views/issueDetails/groupUserFeedback.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ import {space} from 'sentry/styles/space';
1212
import {useLocation} from 'sentry/utils/useLocation';
1313
import useOrganization from 'sentry/utils/useOrganization';
1414
import {useParams} from 'sentry/utils/useParams';
15+
import {FeedbackEmptyState} from 'sentry/views/feedback/feedbackEmptyState';
1516
import {useGroup} from 'sentry/views/issueDetails/useGroup';
1617
import {useGroupUserFeedback} from 'sentry/views/issueDetails/useGroupUserFeedback';
1718
import {useHasStreamlinedUI} from 'sentry/views/issueDetails/utils';
18-
import {UserFeedbackEmpty} from 'sentry/views/userFeedback/userFeedbackEmpty';
1919

2020
function GroupUserFeedback() {
2121
const organization = useOrganization();
@@ -79,7 +79,7 @@ function GroupUserFeedback() {
7979
</FilterMessage>
8080
)}
8181
{reportList.length === 0 ? (
82-
<UserFeedbackEmpty projectIds={[group.project.id]} issueTab />
82+
<FeedbackEmptyState projectIds={[group.project.id]} issueTab />
8383
) : (
8484
<Fragment>
8585
{reportList.map((item, idx) => (

0 commit comments

Comments
 (0)